From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E6F6C48BD5 for ; Tue, 25 Jun 2019 13:39:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32AD12133F for ; Tue, 25 Jun 2019 13:39:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561469976; bh=3muJjXWRycZv3Y/JtYQgT9Oc/WMSWIxkkMKqCMNX5RI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=uvP3knyNW7g6vwMdsKY6er1a+JtJUY5sxKpfNOeP5D0Q70SpnOmkbAHbvEPJD/vY2 Il/7Qg9N5gWUw5dfLSCqrE/aTxVPDuVwJ8u3+NTecdVcHdkEx8xV4qPBnldH4bReKk 5k+85gidzASUT9/y1UFteHx7+FTnF5wTVsaW5DMU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729096AbfFYNjb (ORCPT ); Tue, 25 Jun 2019 09:39:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:46940 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727406AbfFYNjb (ORCPT ); Tue, 25 Jun 2019 09:39:31 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B8A042133F; Tue, 25 Jun 2019 13:39:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561469970; bh=3muJjXWRycZv3Y/JtYQgT9Oc/WMSWIxkkMKqCMNX5RI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hiUdQSgP3fzkh9uQINSrEWWxdCpnUcZOSUINFQIWpnmazGlfb+eIkvMic2wa1obwq MOYLBIk3dgpziyQsVjbfSEPXsH6+/BUjsU3tczSc0CNj21IRV5UqpLgjpqguUV3p1v BvJY98/KPveTSOl42McksrdQHTu0QRNQQWXrFSnU= Date: Tue, 25 Jun 2019 14:39:25 +0100 From: Will Deacon To: Vivek Gautam Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm , Will Deacon , open list , Bjorn Andersson , David Brown , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , robh+dt , Andy Gross , Robin Murphy Subject: Re: [PATCH v3 3/4] iommu/arm-smmu: Add support to handle Qcom's wait-for-safe logic Message-ID: <20190625133924.fqq3y7p3i3fqem5p@willie-the-truck> References: <20190612071554.13573-1-vivek.gautam@codeaurora.org> <20190612071554.13573-4-vivek.gautam@codeaurora.org> <20190614040520.GK22737@tuxbook-pro> <3e1f5e03-6448-8730-056d-fc47bdd71b3f@codeaurora.org> <20190618175218.GH4270@fuggles.cambridge.arm.com> <20190624170348.7dncuc5qezqeyvq2@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Jun 25, 2019 at 12:34:56PM +0530, Vivek Gautam wrote: > On Mon, Jun 24, 2019 at 10:33 PM Will Deacon wrote: > > Instead, I think this needs to be part of a separate file that is maintained > > by you, which follows on from the work that Krishna is doing for nvidia > > built on top of Robin's prototype patches: > > > > http://linux-arm.org/git?p=linux-rm.git;a=shortlog;h=refs/heads/iommu/smmu-impl > > Looking at this branch quickly, it seem there can be separate implementation > level configuration file that can be added. > But will this also handle separate page table ops when required in future. Nothing's set in stone, but having the implementation-specific code constrain the page-table format (especially wrt quirks) sounds reasonable to me. I'm currently waiting for Krishna to respin the nvidia changes [1] on top of this so that we can see how well the abstractions are holding up. I certainly won't merge the stuff until we have a user. Will [1] https://lkml.kernel.org/r/1543887414-18209-1-git-send-email-vdumpa@nvidia.com