From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org,
Deepak Katragadda <dkatraga@codeaurora.org>,
Andy Gross <agross@kernel.org>,
David Brown <david.brown@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, Taniya Das <tdas@codeaurora.org>
Subject: Re: [PATCH v3 1/3] clk: qcom: clk-alpha-pll: Remove post_div_table checks
Date: Mon, 15 Jul 2019 17:08:46 -0700 [thread overview]
Message-ID: <20190716000846.GK30636@minitux> (raw)
In-Reply-To: <20190625063140.17106-2-vkoul@kernel.org>
On Mon 24 Jun 23:31 PDT 2019, Vinod Koul wrote:
> We want users to code properly and fix the post_div_table missing and
> not reply on core to check. So remove the post_div_table check.
s/reply/rely/
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/clk/qcom/clk-alpha-pll.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c
> index b48707693ffd..2c6773188761 100644
> --- a/drivers/clk/qcom/clk-alpha-pll.c
> +++ b/drivers/clk/qcom/clk-alpha-pll.c
> @@ -1036,11 +1036,6 @@ static unsigned long clk_alpha_pll_postdiv_fabia_recalc_rate(struct clk_hw *hw,
> u32 i, div = 1, val;
> int ret;
>
> - if (!pll->post_div_table) {
> - pr_err("Missing the post_div_table for the PLL\n");
> - return -EINVAL;
> - }
> -
> ret = regmap_read(pll->clkr.regmap, PLL_USER_CTL(pll), &val);
> if (ret)
> return ret;
> @@ -1063,11 +1058,6 @@ static long clk_alpha_pll_postdiv_fabia_round_rate(struct clk_hw *hw,
> {
> struct clk_alpha_pll_postdiv *pll = to_clk_alpha_pll_postdiv(hw);
>
> - if (!pll->post_div_table) {
> - pr_err("Missing the post_div_table for the PLL\n");
> - return -EINVAL;
> - }
> -
> return divider_round_rate(hw, rate, prate, pll->post_div_table,
> pll->width, CLK_DIVIDER_ROUND_CLOSEST);
> }
> @@ -1089,11 +1079,6 @@ static int clk_alpha_pll_postdiv_fabia_set_rate(struct clk_hw *hw,
> if (val & PLL_VOTE_FSM_ENA)
> return 0;
>
> - if (!pll->post_div_table) {
> - pr_err("Missing the post_div_table for the PLL\n");
> - return -EINVAL;
> - }
> -
> div = DIV_ROUND_UP_ULL(parent_rate, rate);
> for (i = 0; i < pll->num_post_div; i++) {
> if (pll->post_div_table[i].div == div) {
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-07-16 0:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 6:31 [PATCH v3 0/3] clk: qcom: Add support for SM8150 GCC Vinod Koul
2019-06-25 6:31 ` [PATCH v3 1/3] clk: qcom: clk-alpha-pll: Remove post_div_table checks Vinod Koul
2019-06-27 21:37 ` Stephen Boyd
2019-06-29 11:14 ` Vinod Koul
2019-07-16 0:08 ` Bjorn Andersson [this message]
2019-07-16 4:08 ` Vinod Koul
2019-06-25 6:31 ` [PATCH v3 2/3] clk: qcom: clk-alpha-pll: Add support for Trion PLLs Vinod Koul
2019-06-27 21:50 ` Stephen Boyd
2019-06-29 12:28 ` Vinod Koul
[not found] ` <20190625063140.17106-4-vkoul@kernel.org>
2019-06-27 21:31 ` [PATCH v3 3/3] clk: qcom: gcc: Add global clock controller driver for SM8150 Stephen Boyd
2019-06-29 13:51 ` Vinod Koul
2019-07-15 23:01 ` Stephen Boyd
2019-07-16 4:07 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716000846.GK30636@minitux \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=david.brown@linaro.org \
--cc=dkatraga@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).