From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: agross@kernel.org, robh+dt@kernel.org, will.deacon@arm.com,
robin.murphy@arm.com, joro@8bytes.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
david.brown@linaro.org
Subject: Re: [PATCH v3 4/4] arm64: dts/sdm845: Enable FW implemented safe sequence handler on MTP
Date: Mon, 5 Aug 2019 15:26:27 -0700 [thread overview]
Message-ID: <20190805222627.GA2634@builder> (raw)
In-Reply-To: <20190612071554.13573-5-vivek.gautam@codeaurora.org>
On Wed 12 Jun 00:15 PDT 2019, Vivek Gautam wrote:
> Indicate on MTP SDM845 that firmware implements handler to
> TLB invalidate erratum SCM call where SAFE sequence is toggled
> to achieve optimum performance on real-time clients, such as
> display and camera.
>
> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 78ec373a2b18..6a73d9744a71 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -2368,6 +2368,7 @@
> compatible = "qcom,sdm845-smmu-500", "arm,mmu-500";
> reg = <0 0x15000000 0 0x80000>;
> #iommu-cells = <2>;
> + qcom,smmu-500-fw-impl-safe-errata;
Looked back at this series and started to wonder if there there is a
case where this should not be set? I mean we're after all adding this to
the top 845 dtsi...
How about making it the default in the driver and opt out of the errata
once there is a need?
Regards,
Bjorn
> #global-interrupts = <1>;
> interrupts = <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>,
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
next prev parent reply other threads:[~2019-08-05 22:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 7:15 [PATCH v3 0/4] Qcom smmu-500 wait-for-safe handling for sdm845 Vivek Gautam
2019-06-12 7:15 ` [PATCH v3 1/4] firmware: qcom_scm-64: Add atomic version of qcom_scm_call Vivek Gautam
2019-06-18 17:55 ` Will Deacon
2019-06-19 11:34 ` Vivek Gautam
2019-08-05 22:27 ` Bjorn Andersson
2019-08-08 11:35 ` Vivek Gautam
2019-08-08 16:30 ` Will Deacon
2019-06-12 7:15 ` [PATCH v3 2/4] firmware/qcom_scm: Add scm call to handle smmu errata Vivek Gautam
2019-06-12 7:15 ` [PATCH v3 3/4] iommu/arm-smmu: Add support to handle Qcom's wait-for-safe logic Vivek Gautam
2019-06-14 4:05 ` Bjorn Andersson
2019-06-14 9:18 ` Vivek Gautam
2019-06-18 17:52 ` Will Deacon
2019-06-24 10:28 ` Vivek Gautam
2019-06-24 17:03 ` Will Deacon
2019-06-25 7:04 ` Vivek Gautam
2019-06-25 13:39 ` Will Deacon
2019-06-26 6:33 ` Vivek Gautam
2019-06-26 14:48 ` Will Deacon
2019-06-27 7:05 ` Vivek Gautam
2019-06-14 13:15 ` Marc Gonzalez
2019-06-17 9:50 ` Vivek Gautam
2019-06-17 10:48 ` Marc Gonzalez
2019-06-12 7:15 ` [PATCH v3 4/4] arm64: dts/sdm845: Enable FW implemented safe sequence handler on MTP Vivek Gautam
2019-06-14 4:06 ` Bjorn Andersson
2019-06-14 9:01 ` Vivek Gautam
2019-08-05 22:26 ` Bjorn Andersson [this message]
2019-08-11 16:08 ` Vivek Gautam
2019-08-11 19:01 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805222627.GA2634@builder \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=vivek.gautam@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).