From: Brian Masney <masneyb@onstation.org>
To: Georgi Djakov <georgi.djakov@linaro.org>, bjorn.andersson@linaro.org
Cc: robh+dt@kernel.org, agross@kernel.org, vkoul@kernel.org,
evgreen@chromium.org, daidavid1@codeaurora.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v5 4/5] interconnect: qcom: Add QCS404 interconnect provider driver
Date: Sun, 25 Aug 2019 16:41:55 -0400 [thread overview]
Message-ID: <20190825204155.GA6879@onstation.org> (raw)
In-Reply-To: <20190723142339.27772-5-georgi.djakov@linaro.org>
Hi Georgi and Bjorn,
I'm finishing up a msm8974 interconnect driver and I used qcs404 as a
starting point. I have a question below.
On Tue, Jul 23, 2019 at 05:23:38PM +0300, Georgi Djakov wrote:
> From: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> Add driver for the interconnect buses found in Qualcomm QCS404-based
> platforms. The topology consists of three NoCs that are controlled by
> a remote processor. This remote processor collects the aggregated
> bandwidth for each master-slave pairs.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> ---
[snip]
> +enum {
> + QCS404_MASTER_AMPSS_M0 = 1,
[snip]
> +#define DEFINE_QNODE(_name, _id, _buswidth, _mas_rpm_id, _slv_rpm_id, \
> + ...) \
> + static struct qcom_icc_node _name = { \
> + .name = #_name, \
> + .id = _id, \
> + .buswidth = _buswidth, \
> + .mas_rpm_id = _mas_rpm_id, \
> + .slv_rpm_id = _slv_rpm_id, \
> + .num_links = ARRAY_SIZE(((int[]){ __VA_ARGS__ })), \
> + .links = { __VA_ARGS__ }, \
> + }
> +
> +DEFINE_QNODE(mas_apps_proc, QCS404_MASTER_AMPSS_M0, 8, 0, -1, QCS404_SLAVE_EBI_CH0, QCS404_BIMC_SNOC_SLV);
[snip]
> +static struct qcom_icc_node *qcs404_bimc_nodes[] = {
> + [MASTER_AMPSS_M0] = &mas_apps_proc,
Should the id in DEFINE_QNODE() above be MASTER_AMPSS_M0 instead of
QCS404_MASTER_AMPSS_M0?
of_icc_xlate_onecell() looks up the id by the array index
MASTER_AMPSS_M0 (1), however qnoc_probe() passes the id that's
in struct qcom_icc_node to icc_node_create(), which is
QCS404_MASTER_AMPSS_M0 (0). They have different values and I'm unsure
why we can't just use the ids that are in qcom,qcs404.h and drop the
enum above.
Thanks,
Brian
next prev parent reply other threads:[~2019-08-25 20:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 14:23 [PATCH v5 0/5] Add QCS404 interconnect provider driver Georgi Djakov
2019-07-23 14:23 ` [PATCH v5 1/5] dt-bindings: interconnect: Add Qualcomm QCS404 DT bindings Georgi Djakov
2019-08-05 13:50 ` Georgi Djakov
2019-08-12 14:07 ` Georgi Djakov
2019-08-13 15:32 ` Rob Herring
2019-07-23 14:23 ` [PATCH v5 2/5] soc: qcom: smd-rpm: Create RPM interconnect proxy child device Georgi Djakov
2019-07-23 14:23 ` [PATCH v5 3/5] interconnect: qcom: Add interconnect SMD over SMD driver Georgi Djakov
2019-07-23 14:23 ` [PATCH v5 4/5] interconnect: qcom: Add QCS404 interconnect provider driver Georgi Djakov
2019-08-25 20:41 ` Brian Masney [this message]
2019-09-02 21:29 ` Brian Masney
2019-07-23 14:23 ` [PATCH v5 5/5] arm64: dts: qcs404: Add interconnect provider DT nodes Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190825204155.GA6879@onstation.org \
--to=masneyb@onstation.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=daidavid1@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).