On Mon, Feb 10, 2020 at 03:00:55PM -0500, Adam Serbinski wrote: > On 2020-02-10 13:26, Mark Brown wrote: > > To repeat my comment on another patch in the series there should still > > be some representation of the DAI for this device in the kernel. > Respectfully, I'm not sure I understand what it is that you are suggesting. > Is it your intention to suggest that instead of adding controls to the > machine driver, I should instead write a codec driver to contain those > controls? I have already separately said that you should write a CODEC driver for this CODEC. I'm saying that this seems like the sort of thing that might fit in that CODEC driver. > Or is it your intention to suggest that something within the kernel is > already aware of the rate to be set, and it is that which should set the > rate rather than a control? That would be one example of how such a CODEC driver could be configured, and is how other baseband/BT devices have ended up going (see cx20442.c for example).