From: Rob Herring <robh@kernel.org>
To: Wesley Cheng <wcheng@codeaurora.org>
Cc: sboyd@kernel.org, heikki.krogerus@linux.intel.com,
agross@kernel.org, gregkh@linuxfoundation.org,
bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, jackp@codeaurora.org,
sergei.shtylyov@gmail.com
Subject: Re: [PATCH v10 4/4] arm64: boot: dts: qcom: pm8150b: Add DTS node for PMIC VBUS booster
Date: Tue, 13 Oct 2020 10:03:16 -0500 [thread overview]
Message-ID: <20201013150316.GB3497815@bogus> (raw)
In-Reply-To: <20201008235934.8931-5-wcheng@codeaurora.org>
On Thu, Oct 08, 2020 at 04:59:34PM -0700, Wesley Cheng wrote:
> Add the required DTS node for the USB VBUS output regulator, which is
> available on PM8150B. This will provide the VBUS source to connected
> peripherals.
>
> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/pm8150b.dtsi | 6 ++++++
> arch/arm64/boot/dts/qcom/sm8150-mtp.dts | 4 ++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8150b.dtsi b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> index 2bf385f5a55a..49ea597cc0c5 100644
> --- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> @@ -53,6 +53,12 @@ power-on@800 {
> status = "disabled";
> };
>
> + pm8150b_vbus: regulator@1100 {
> + compatible = "qcom,pm8150b-vbus-reg";
> + status = "disabled";
> + reg = <0x1100>;
> + };
> +
> pm8150b_typec: usb-typec@1500 {
> compatible = "qcom,pm8150b-usb-typec";
> status = "disabled";
> diff --git a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts
> index 6c6325c3af59..ba3b5b802954 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts
> @@ -409,6 +409,10 @@ &ufs_mem_phy {
> vdda-pll-max-microamp = <19000>;
> };
>
> +&pm8150b_vbus {
> + status = "okay";
> +};
Why aren't you enabling the TypeC node and providing a complete example?
> +
> &usb_1_hsphy {
> status = "okay";
> vdda-pll-supply = <&vdd_usb_hs_core>;
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2020-10-13 15:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 23:59 [PATCH v10 0/4] Introduce PMIC based USB type C detection Wesley Cheng
2020-10-08 23:59 ` [PATCH v10 1/4] usb: typec: Add QCOM PMIC typec detection driver Wesley Cheng
2020-10-08 23:59 ` [PATCH v10 2/4] dt-bindings: usb: Add Qualcomm PMIC type C controller dt-binding Wesley Cheng
2020-10-13 15:00 ` Rob Herring
2020-10-14 8:59 ` Wesley Cheng
2022-12-13 14:05 ` Konrad Dybcio
2020-10-08 23:59 ` [PATCH v10 3/4] arm64: boot: dts: qcom: pm8150b: Add node for USB type C block Wesley Cheng
2020-10-08 23:59 ` [PATCH v10 4/4] arm64: boot: dts: qcom: pm8150b: Add DTS node for PMIC VBUS booster Wesley Cheng
2020-10-13 15:03 ` Rob Herring [this message]
2020-10-14 9:05 ` Wesley Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013150316.GB3497815@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jackp@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=sergei.shtylyov@gmail.com \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).