From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm8250: remove wakeup-parent for TLMM node
Date: Tue, 27 Oct 2020 23:40:56 -0500 [thread overview]
Message-ID: <20201028044056.GA3151@builder.lan> (raw)
In-Reply-To: <20201027015420.908945-1-dmitry.baryshkov@linaro.org>
On Mon 26 Oct 20:54 CDT 2020, Dmitry Baryshkov wrote:
> On SM8250 TLMM doesn't use PDC interrupt controller for wakeup events.
> Instead it handles them on their own (not implemented yet). In addition
> setting wakeup-parent property to &pdc will result in parent hwirq being
> set to ~0UL, which interact badly with the irqdomains trimming code. So
> remove the wakeup-parent property.
>
Would you accept this patch instead?
https://lore.kernel.org/r/20201028043642.1141723-1-bjorn.andersson@linaro.org
Regards,
Bjorn
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Fixes: 16951b490b20 ("arm64: dts: qcom: sm8250: Add TLMM pinctrl node")
> ---
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index ccbdb47d6119..77ea20421752 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -2418,7 +2418,6 @@ tlmm: pinctrl@f100000 {
> interrupt-controller;
> #interrupt-cells = <2>;
> gpio-ranges = <&tlmm 0 0 180>;
> - wakeup-parent = <&pdc>;
>
> pri_mi2s_sck_active: pri-mi2s-sck-active {
> mux {
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-10-29 0:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 1:54 [PATCH] arm64: dts: qcom: sm8250: remove wakeup-parent for TLMM node Dmitry Baryshkov
2020-10-28 4:40 ` Bjorn Andersson [this message]
2020-10-28 11:52 ` Dmitry Baryshkov
2020-11-03 17:40 ` Bjorn Andersson
2020-11-03 23:53 ` Dmitry Baryshkov
2020-11-04 1:09 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028044056.GA3151@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).