From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2080C4363A for ; Wed, 28 Oct 2020 22:31:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9489F20725 for ; Wed, 28 Oct 2020 22:31:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="TT6mUTgT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387902AbgJ1Wb3 (ORCPT ); Wed, 28 Oct 2020 18:31:29 -0400 Received: from m42-4.mailgun.net ([69.72.42.4]:63932 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387897AbgJ1Wb2 (ORCPT ); Wed, 28 Oct 2020 18:31:28 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1603924288; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=Uun2BBWyN9O6gGUON67BLRc5oqgnJ4TIcEJ9tL9SWV0=; b=TT6mUTgTmMM58vVGkFiXC8TfoIySxWLa1qjHUFKnicmB7073ddl7Tq2ckdazVJXIMz5lPYSw H8eW6iX9pCzuzfFPV4Q10lyyJI8faeU9EDehsHOkt3Kvw8Bnl7V1YCpKolG2hz69YxPFbZ9B zxiCEkyOunw2pTNYrccKwlLhVBo= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 5f9981ab4e4fe7071da1fdae (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 28 Oct 2020 14:35:23 GMT Sender: ilina=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D8CCEC433F0; Wed, 28 Oct 2020 14:35:22 +0000 (UTC) Received: from localhost (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: ilina) by smtp.codeaurora.org (Postfix) with ESMTPSA id 26B23C433CB; Wed, 28 Oct 2020 14:35:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 26B23C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=ilina@codeaurora.org Date: Wed, 28 Oct 2020 08:35:21 -0600 From: Lina Iyer To: Anders Roxell Cc: agross@kernel.org, Bjorn Andersson , linux-arm-msm@vger.kernel.org, Linux Kernel Mailing List , mkshah@codeaurora.org Subject: Re: [PATCH] soc: qcom: QCOM_RPMH fix build with modular QCOM_RPMH Message-ID: <20201028143521.GD19979@codeaurora.org> References: <20201027111422.4008114-1-anders.roxell@linaro.org> <20201027211536.GB19979@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Oct 28 2020 at 03:43 -0600, Anders Roxell wrote: >On Tue, 27 Oct 2020 at 22:15, Lina Iyer wrote: >> >> Hi Anders, >> >> On Tue, Oct 27 2020 at 05:14 -0600, Anders Roxell wrote: >> >When building allmodconfig leading to the following link error with >> >CONFIG_QCOM_RPMH=y and CONFIG_QCOM_COMMAND_DB=m: >> > >> >aarch64-linux-gnu-ld: drivers/clk/qcom/clk-rpmh.o: in function `clk_rpmh_probe': >> > drivers/clk/qcom/clk-rpmh.c:474: undefined reference to `cmd_db_read_addr' >> > drivers/clk/qcom/clk-rpmh.c:474:(.text+0x254): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `cmd_db_read_addr' >> > >> >Fix this by adding a Kconfig depenency and forcing QCOM_RPMH to be a >> >module when QCOM_COMMAND_DB is a module. Also removing the dependency on >> >'ARCH_QCOM || COMPILE_TEST' since that is already a dependency for >> >QCOM_COMMAND_DB. >> > >> >Fixes: 778279f4f5e4 ("soc: qcom: cmd-db: allow loading as a module") >> >Signed-off-by: Anders Roxell >> >--- >> > drivers/soc/qcom/Kconfig | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> >diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig >> >index 9b4ae9c16ba7..3bdd1604f78f 100644 >> >--- a/drivers/soc/qcom/Kconfig >> >+++ b/drivers/soc/qcom/Kconfig >> >@@ -109,7 +109,7 @@ config QCOM_RMTFS_MEM >> > >> > config QCOM_RPMH >> > tristate "Qualcomm RPM-Hardened (RPMH) Communication" >> >- depends on ARCH_QCOM || COMPILE_TEST >> >+ depends on QCOM_COMMAND_DB >> A solution was posted in the mailing list alredy - >> https://lore.kernel.org/linux-arm-msm/20201008040907.7036-1-ilina@codeaurora.org/ > >I missed that one, thanks. > >> >> If you get a chance, please give that a shot to see if that works for >> you. > >That will work too, but the "depends on ARCH_QCOM || COMPILE_TEST" >isn't needed since that is already the dependency for QCOM_COMMAND_DB. >So that should be met here too or am I missing something? > Sure, if you want to post an update to the patch, that would be fine too. Bjorn: Have you picked up this patch yet? If he hasn't please feel free to update the patch. Or, I can do that as well. --Lina >Cheers, >Anders > >> >> Thanks, >> Lina >> >> > help >> > Support for communication with the hardened-RPM blocks in >> > Qualcomm Technologies Inc (QTI) SoCs. RPMH communication uses an >> >-- >> >2.28.0 >> >