Re: [PATCH v9 01/15] dt-bindings: thermal: qcom: add adc-thermal monitor bindings

From: Jonathan Cameron <jic23@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Jishnu Prakash <jprakash@qti.qualcomm.com>,
	Zhang Rui <rui.zhang@intel.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Amit Kucheria <amitk@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>, Andy Gross <agross@kernel.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	devicetree@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	linux-iio@vger.kernel.org,
	Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH v9 01/15] dt-bindings: thermal: qcom: add adc-thermal monitor bindings
Date: Sun, 8 Nov 2020 15:52:13 +0000	[thread overview]
Message-ID: <20201108155213.1c91e3b9@archlinux> (raw)
In-Reply-To: <20201104183230.GB3913864@bogus>

On Wed, 4 Nov 2020 12:32:30 -0600
Rob Herring <robh@kernel.org> wrote:

> On Mon, 02 Nov 2020 20:49:36 +0300, Dmitry Baryshkov wrote:
> > Add bindings for thermal monitor, part of Qualcomm PMIC5 chips. It is a
> > close counterpart of VADC part of those PMICs.
> > 
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > Reviewed-by: Rob Herring <robh@kernel.org>

Ah, this got picked up by the additions I made to dt-schema the other day.

So there are a few existing places where io-channel-ranges is miss provided
in dtsi files for io-channel providers (it's being ignored in most the places
it is specified!)

What it means is that the child nodes may use io-channel entries of their parent.
Hence it should only be specified on the consumer side.
Here we don't actually need it for the consumer either as the io-channels
entry is in the child node, not the parent.

I'm kind of assuming that I'll eventually do the immutable branch for this
series. If so I can clean this up whilst applying if everything else is fine
with v9.

Thanks,

Jonathan

> > ---
> >  .../bindings/thermal/qcom-spmi-adc-tm5.yaml   | 154 ++++++++++++++++++
> >  1 file changed, 154 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml
> >   
> 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: adc@3100: 'io-channels' is a dependency of 'io-channel-ranges'
> 	From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/iio/iio-consumer.yaml
> 
> 
> See https://patchwork.ozlabs.org/patch/1392425
> 
> The base for the patch is generally the last rc1. Any dependencies
> should be noted.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit.
> 