Re: [PATCH v2 1/2] mhi: unconstify mhi_event_config

[Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>]

On Wed, Jan 06, 2021 at 09:39:27AM +0100, Loic Poulain wrote:
> Hi Hemant,
> 
> On Wed, 6 Jan 2021 at 03:28, Hemant Kumar <hemantk@codeaurora.org> wrote:
> 
> > Hi Loic
> >
> > On 1/5/21 8:44 AM, Loic Poulain wrote:
> > > Some parameters may have to be determined at runtime.
> > > It is the case for the event ring MSI vector.
> > >
> > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > ---
> > >   v2: no change
> > >
> > >   include/linux/mhi.h | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> > > index 62da830..48b1b2a 100644
> > > --- a/include/linux/mhi.h
> > > +++ b/include/linux/mhi.h
> > > @@ -290,7 +290,7 @@ struct mhi_controller_config {
> > >       u32 num_channels;
> > >       const struct mhi_channel_config *ch_cfg;
> > >       u32 num_events;
> > > -     const struct mhi_event_config *event_cfg;
> > > +     struct mhi_event_config *event_cfg;
> > commented on previous patch set, copying my comment here
> > Do we need to update mhi controller driver like ath11k and generic pci
> > driver to avoid compiler warnings?
> >
> 
> ath11k does declare its mhi_event_config as const so it should not cause
> any issue. mhi_pci_generic event config is modified in 2/2.
> 

Ath11k doesn't declare it as const. It might be an issue before but not now ;)

Thanks,
Mani

> Regards,
> Loic