From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stanimir Varbanov <svarbanov@mm-sol.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 2/5] arm64: qcom: dts: qrb5165-rb5: add qca6391 power device
Date: Sat, 30 Jan 2021 09:29:39 +0530 [thread overview]
Message-ID: <20210130035939.GA3544@work> (raw)
In-Reply-To: <YBTW2et0IVCUGmdg@builder.lan>
On Fri, Jan 29, 2021 at 09:47:37PM -0600, Bjorn Andersson wrote:
> On Thu 28 Jan 11:52 CST 2021, Dmitry Baryshkov wrote:
>
> > Add qca6391 to device tree as a way to provide power domain to WiFi and
> > BT parts of the chip.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > ---
> > arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 61 ++++++++++++++++++++++++
> > 1 file changed, 61 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> > index 8aebc3660b11..2b0c1cc9333b 100644
> > --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> > +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> > @@ -151,6 +151,23 @@ vreg_s4a_1p8: vreg-s4a-1p8 {
> > regulator-max-microvolt = <1800000>;
> > regulator-always-on;
> > };
> > +
> > + qca6391: qca6391 {
> > + compatible = "qcom,qca6390";
> > + #power-domain-cells = <0>;
> > +
> > + vddaon-supply = <&vreg_s6a_0p95>;
> > + vddpmu-supply = <&vreg_s2f_0p95>;
> > + vddrfa1-supply = <&vreg_s2f_0p95>;
> > + vddrfa2-supply = <&vreg_s8c_1p3>;
> > + vddrfa3-supply = <&vreg_s5a_1p9>;
> > + vddpcie1-supply = <&vreg_s8c_1p3>;
> > + vddpcie2-supply = <&vreg_s5a_1p9>;
> > + vddio-supply = <&vreg_s4a_1p8>;
> > + pinctrl-names = "default", "active";
> > + pinctrl-0 = <&wlan_default_state &bt_default_state>;
> > + pinctrl-1 = <&wlan_active_state &bt_active_state>;
>
> I dislike the use of pinctrl states for toggling the level of the gpio
> and would prefer that you use the gpio binding and api for this instead.
>
> > + };
> > };
> >
> > &adsp {
> > @@ -1013,6 +1030,28 @@ &tlmm {
> > "HST_WLAN_UART_TX",
> > "HST_WLAN_UART_RX";
> >
> > + bt_default_state: bt-default-state {
>
> Are you sure you need to drive the BT_EN pin in order to have WiFi
> working? On QCA6174 I believe the "WL_EN" was actually RESET_N and BT_EN
> was actually "blueooth enable" - so we wired that in the bluetooth node
> instead.
>
IIRC, that's the case. We need both BT_EN and WL_EN for proper bringup of the
chip.
Thanks,
Mani
next prev parent reply other threads:[~2021-01-30 9:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 17:52 [PATCH v2 0/5] Add support for Qualcomm QCA639x chips family Dmitry Baryshkov
2021-01-28 17:52 ` [PATCH v2 1/5] misc: qca639x: add support for QCA639x powerup sequence Dmitry Baryshkov
2021-01-31 14:18 ` Kalle Valo
2021-01-28 17:52 ` [PATCH v2 2/5] arm64: qcom: dts: qrb5165-rb5: add qca6391 power device Dmitry Baryshkov
2021-01-30 3:47 ` Bjorn Andersson
2021-01-30 3:59 ` Manivannan Sadhasivam [this message]
2021-01-28 17:52 ` [PATCH v2 3/5] pcie-qcom: provide a way to power up qca6390 chip on RB5 platform Dmitry Baryshkov
[not found] ` <CAL_JsqLRn40h0K-Fze5m1LS2+raLp94LariMkUh7XtekTBT5+Q@mail.gmail.com>
2021-01-29 3:45 ` Dmitry Baryshkov
2021-01-29 21:50 ` Bjorn Helgaas
2021-01-29 22:19 ` Dmitry Baryshkov
2021-01-29 22:39 ` Bjorn Helgaas
2021-01-30 3:53 ` Bjorn Andersson
2021-01-30 16:14 ` Dmitry Baryshkov
2021-02-02 19:48 ` Bjorn Andersson
2021-02-02 21:37 ` Rob Herring
2021-02-02 21:50 ` Bjorn Andersson
2021-02-03 4:14 ` Dmitry Baryshkov
2021-01-29 23:39 ` Rob Herring
2021-06-13 18:40 ` Konrad Dybcio
2021-01-28 17:52 ` [PATCH v2 4/5] arm64: dtb: qcom: qrb5165-rb5: add bridge@0,0 to power up qca6391 chip Dmitry Baryshkov
[not found] ` <CAL_Jsq+uim_0fDsCqSjgbz-xzUEu4GAf+KOgxSd1KdrFWjhd3Q@mail.gmail.com>
2021-01-29 3:48 ` Dmitry Baryshkov
2021-01-28 17:52 ` [PATCH v2 5/5] arm64: dts: qcom: Add Bluetooth support on RB5 Dmitry Baryshkov
[not found] ` <CAL_Jsq+nNRv3KceHthgktHR1oRMs+eKWC4O7n0k78izs1aTPfA@mail.gmail.com>
2021-01-29 3:49 ` Dmitry Baryshkov
2021-02-02 6:16 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210130035939.GA3544@work \
--to=manivannan.sadhasivam@linaro.org \
--cc=agross@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh+dt@kernel.org \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).