From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4817CC43603 for ; Fri, 16 Apr 2021 22:41:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EAB18613DA for ; Fri, 16 Apr 2021 22:41:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235153AbhDPWlh (ORCPT ); Fri, 16 Apr 2021 18:41:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235043AbhDPWld (ORCPT ); Fri, 16 Apr 2021 18:41:33 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFE93C06138A for ; Fri, 16 Apr 2021 15:41:07 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id m18so12520921plc.13 for ; Fri, 16 Apr 2021 15:41:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DFM8liF/M0xdOJLWarwocCWEWNZPfb1MoRCxfTIdoG4=; b=R1ZV6OrerC1010l29PrywmSUIvHfXf06HH7yhI1yG+h5k4X7/yLM+e9GkaeGj1Qz+H a2A7fiV/+deWlVIRXkHUtUY7+p45jCy/DFVOTwfEG1ltxcpHdGMp+skwlySthUD0wojh tRpIYmITlzuwj/MMBzpORlgsB3ccG6UXCHXw0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DFM8liF/M0xdOJLWarwocCWEWNZPfb1MoRCxfTIdoG4=; b=t5rvtZV5KcqvYfM7BXKnf3Q5ktLZ3nNQEzm1HDQinLudJU1yJRlO7H2mzymV8M4eoF GheApTpLazkIAJVmQXmVjcg6ssksufT5GI4W0ADq1j377MpBrcnI7SP9dL2pUIYC37yK n2p2NiHzacLNQ8qVRQYyO++MueKEAYp5eqcH/W+1DLkwE9UA22zBulo3Mb1L3sUrHsvk rIn0UIudMrRSl6T5YtZv/o2YtXXq0p/Y9FBcPI8oC7PfAJOcejgDQD3qoNsLZk96Ah5M 9uk4rwC1x2GG2SQ2v1I95rW2KUaNq+jMVm85eyHCipQ96PC9E8+5UzU8N7mzdgW1cEsn E74Q== X-Gm-Message-State: AOAM532z8eWQDHwkbOOCwHncN2j1kI3LW62aont05qlBbgA4eH4v3kFC t61S51GCDrN54E+gUxzOTFTeaQ== X-Google-Smtp-Source: ABdhPJyvWWjd+DHCZICjcW8hN5oKKncQlVhyFnMlkZ6SzJVXeRjAeJrO14HIwCTmtT73LHzsKF8HAA== X-Received: by 2002:a17:902:c94f:b029:ec:85bd:1f24 with SMTP id i15-20020a170902c94fb02900ec85bd1f24mr2964510pla.4.1618612867526; Fri, 16 Apr 2021 15:41:07 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:dc8a:c9d0:aa5b:5386]) by smtp.gmail.com with ESMTPSA id r6sm5633659pgp.64.2021.04.16.15.41.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 15:41:07 -0700 (PDT) From: Douglas Anderson To: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , Wolfram Sang Cc: Stephen Boyd , robdclark@chromium.org, Maarten Lankhorst , Stanislav Lisovskiy , Steev Klimaszewski , Bjorn Andersson , linux-arm-msm@vger.kernel.org, Linus W , Douglas Anderson , Daniel Vetter , David Airlie , Robert Foss , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 13/27] drm/bridge: ti-sn65dsi86: Use devm to do our runtime_disable Date: Fri, 16 Apr 2021 15:39:36 -0700 Message-Id: <20210416153909.v4.13.I1e627eb5f316c0cf6595b120e6e262f5bf890300@changeid> X-Mailer: git-send-email 2.31.1.368.gbe11c130af-goog In-Reply-To: <20210416223950.3586967-1-dianders@chromium.org> References: <20210416223950.3586967-1-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org There's no devm_runtime_enable(), but it's easy to use devm_add_action_or_reset() and means we don't need to worry about the disable in our remove() routine or in error paths. No functional changes intended by this change. Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/gpu/drm/bridge/ti-sn65dsi86.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index a200e88fd006..53f1f7b3022f 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -1223,6 +1223,11 @@ static void ti_sn_bridge_parse_lanes(struct ti_sn65dsi86 *pdata, pdata->ln_polrs = ln_polrs; } +static void ti_sn65dsi86_runtime_disable(void *data) +{ + pm_runtime_disable(data); +} + static int ti_sn65dsi86_probe(struct i2c_client *client, const struct i2c_device_id *id) { @@ -1278,12 +1283,13 @@ static int ti_sn65dsi86_probe(struct i2c_client *client, return ret; pm_runtime_enable(dev); + ret = devm_add_action_or_reset(dev, ti_sn65dsi86_runtime_disable, dev); + if (ret) + return ret; ret = ti_sn_setup_gpio_controller(pdata); - if (ret) { - pm_runtime_disable(dev); + if (ret) return ret; - } pdata->aux.name = "ti-sn65dsi86-aux"; pdata->aux.dev = dev; @@ -1316,8 +1322,6 @@ static int ti_sn65dsi86_remove(struct i2c_client *client) drm_bridge_remove(&pdata->bridge); - pm_runtime_disable(pdata->dev); - of_node_put(pdata->host_node); return 0; -- 2.31.1.368.gbe11c130af-goog