From: Marijn Suijten <marijn.suijten@somainline.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 07/12] arm64: dts: qcom: sdm630: fix gpu's interconnect path
Date: Sun, 15 May 2022 16:51:08 +0200 [thread overview]
Message-ID: <20220515145108.zfmlb53vacx7sr33@SoMainline.org> (raw)
In-Reply-To: <20220514190138.3179964-8-dmitry.baryshkov@linaro.org>
On 2022-05-14 22:01:33, Dmitry Baryshkov wrote:
> ICC path for the GPU incorrectly states <&gnoc 1 &bimc 5>, which is
> a path from SLAVE_GNOC_BIMC to SLAVE_EBI. According to the downstream
Nit: "the downstream" -> "downstream sources(,) the"
> GPU uses MASTER_OXILI here, <&bimc 1 ...>.
"here, which is equivalent to <&bimc 1 ...> [upstream/mainline/here]"
>
> Fixes: 5cf69dcbec8b ("arm64: dts: qcom: sdm630: Add Adreno 508 GPU configuration")
> Reported-by: Marijn Suijten <marijn.suijten@somainline.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
> ---
> arch/arm64/boot/dts/qcom/sdm630.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> index 2b5dbc12bdf8..6d0bc9e8fb5b 100644
> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> @@ -1045,7 +1045,7 @@ adreno_gpu: gpu@5000000 {
> nvmem-cells = <&gpu_speed_bin>;
> nvmem-cell-names = "speed_bin";
>
> - interconnects = <&gnoc 1 &bimc 5>;
> + interconnects = <&bimc 1 &bimc 5>;
> interconnect-names = "gfx-mem";
>
> operating-points-v2 = <&gpu_sdm630_opp_table>;
> --
> 2.35.1
>
next prev parent reply other threads:[~2022-05-15 14:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-14 19:01 [PATCH v5 00/12] arm64: dts: qcom: initial Inforce IFC6560 board support Dmitry Baryshkov
2022-05-14 19:01 ` [PATCH v5 01/12] arm64: dts: qcom: sdm630: disable dsi0/dsi0_phy by default Dmitry Baryshkov
2022-05-15 14:45 ` Marijn Suijten
2022-05-14 19:01 ` [PATCH v5 02/12] arm64: dts: qcom: sdm660: disable dsi1/dsi1_phy " Dmitry Baryshkov
2022-05-14 19:01 ` [PATCH v5 03/12] arm64: dts: qcom: sdm630: disable GPU " Dmitry Baryshkov
2022-05-14 19:01 ` [PATCH v5 04/12] arm64: dts: qcom: sdm630: fix the qusb2phy ref clock Dmitry Baryshkov
2022-05-14 19:01 ` [PATCH v5 05/12] arm64: dts: qcom: sdm630: rename qusb2phy to qusb2phy0 Dmitry Baryshkov
2022-05-15 14:47 ` Marijn Suijten
2022-05-14 19:01 ` [PATCH v5 06/12] arm64: dts: qcom: sdm630: add second (HS) USB host support Dmitry Baryshkov
2022-05-15 14:48 ` Marijn Suijten
2022-05-14 19:01 ` [PATCH v5 07/12] arm64: dts: qcom: sdm630: fix gpu's interconnect path Dmitry Baryshkov
2022-05-15 14:51 ` Marijn Suijten [this message]
2022-05-14 19:01 ` [PATCH v5 08/12] arm64: dts: qcom: sdm630: use defined symbols for interconnects Dmitry Baryshkov
2022-05-15 14:52 ` Marijn Suijten
2022-05-14 19:01 ` [PATCH v5 09/12] arm64: dts: qcom: sdm636-sony-xperia-ganges-mermaid: correct sdc2 pinconf Dmitry Baryshkov
2022-05-15 14:53 ` Marijn Suijten
2022-05-14 19:01 ` [PATCH v5 10/12] arm64: dts: qcom: sdm660: move SDHC2 card detect pinconf to board files Dmitry Baryshkov
2022-05-15 14:54 ` Marijn Suijten
2022-05-14 19:01 ` [PATCH v5 11/12] arm64: dts: qcom: sdm660: Add initial Inforce IFC6560 board support Dmitry Baryshkov
2022-05-15 14:56 ` Marijn Suijten
2022-05-15 17:42 ` Dmitry Baryshkov
2022-05-14 19:01 ` [PATCH v5 12/12] dt-bindings: arm: qcom: document sda660 SoC and ifc6560 board Dmitry Baryshkov
2022-05-15 14:57 ` Marijn Suijten
2022-05-16 6:53 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220515145108.zfmlb53vacx7sr33@SoMainline.org \
--to=marijn.suijten@somainline.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).