From: Sivaprakash Murugesan <sivaprak@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: agross@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
robh+dt@kernel.org, jassisinghbrar@gmail.com,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 7/8] mailbox: qcom: Add ipq6018 apcs compatible
Date: Sun, 24 May 2020 15:15:47 +0530 [thread overview]
Message-ID: <32f33ed2-7c00-3967-e34b-424c5906a91b@codeaurora.org> (raw)
In-Reply-To: <20200512201931.GJ2165@builder.lan>
Hi Bjorn,
On 5/13/2020 1:49 AM, Bjorn Andersson wrote:
> On Sun 03 May 23:20 PDT 2020, Sivaprakash Murugesan wrote:
>
>> The Qualcomm ipq6018 has apcs block, add compatible for the same.
>> Also, the apcs provides a clock controller functionality similar
>> to msm8916 but the clock driver is different.
>>
>> Create a child platform device based on the apcs compatible for the
>> clock controller functionality.
>>
>> Signed-off-by: Sivaprakash Murugesan <sivaprak@codeaurora.org>
>> ---
>> drivers/mailbox/qcom-apcs-ipc-mailbox.c | 26 +++++++++++++++++---------
>> 1 file changed, 17 insertions(+), 9 deletions(-)
>>
>> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
>> index eeebafd..7c0c4b0 100644
>> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
>> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
>> @@ -45,6 +45,16 @@ static const struct mbox_chan_ops qcom_apcs_ipc_ops = {
>> .send_data = qcom_apcs_ipc_send_data,
>> };
>>
>> +static const struct of_device_id apcs_clk_match_table[] = {
>> + { .compatible = "qcom,msm8916-apcs-kpss-global",
>> + .data = "qcom-apcs-msm8916-clk", },
> These are easier to read if you ignore the 80-char limit.
> Unless Jassi's object that is.
since Jassi has not objected your comment, I am making the change as per
your suggestion.
>
>> + { .compatible = "qcom,qcs404-apcs-apps-global",
>> + .data = "qcom-apcs-msm8916-clk", },
>> + { .compatible = "qcom,ipq6018-apcs-apps-global",
> Add your entry on top, to maintain sort order.
ok.
>
>> + .data = "qcom,apss-ipq-clk", },
>> + {}
>> +};
>> +
>> static int qcom_apcs_ipc_probe(struct platform_device *pdev)
>> {
>> struct qcom_apcs_ipc *apcs;
>> @@ -54,11 +64,7 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
>> void __iomem *base;
>> unsigned long i;
>> int ret;
>> - const struct of_device_id apcs_clk_match_table[] = {
>> - { .compatible = "qcom,msm8916-apcs-kpss-global", },
>> - { .compatible = "qcom,qcs404-apcs-apps-global", },
>> - {}
>> - };
>> + const struct of_device_id *clk_device;
>>
>> apcs = devm_kzalloc(&pdev->dev, sizeof(*apcs), GFP_KERNEL);
>> if (!apcs)
>> @@ -93,11 +99,12 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
>> return ret;
>> }
>>
>> - if (of_match_device(apcs_clk_match_table, &pdev->dev)) {
>> + clk_device = of_match_device(apcs_clk_match_table, &pdev->dev);
> Better use of_device_match_data() and get the string directly (or NULL).
As I checked there is no API called of_device_match_data(), the API
of_device_get_match_data()
returns the data associated with the device and it cannot be used here.
please correct me if wrong.
>
>> + if (clk_device) {
>> apcs->clk = platform_device_register_data(&pdev->dev,
>> - "qcom-apcs-msm8916-clk",
>> - PLATFORM_DEVID_NONE,
>> - NULL, 0);
>> + (const char *)clk_device->data,
>> + PLATFORM_DEVID_NONE,
>> + NULL, 0);
> I didn't apply the patch to look for myself, but please ensure to
> maintain indentation to follow the parenthesis on the line before.
ok.
>
>> if (IS_ERR(apcs->clk))
>> dev_err(&pdev->dev, "failed to register APCS clk\n");
>> }
>> @@ -127,6 +134,7 @@ static const struct of_device_id qcom_apcs_ipc_of_match[] = {
>> { .compatible = "qcom,sdm845-apss-shared", .data = (void *)12 },
>> { .compatible = "qcom,sm8150-apss-shared", .data = (void *)12 },
>> { .compatible = "qcom,ipq8074-apcs-apps-global", .data = (void *)8 },
>> + { .compatible = "qcom,ipq6018-apcs-apps-global", .data = (void *)8 },
> Add it one line up and you'll maintain partial sorting...
ok.
next prev parent reply other threads:[~2020-05-24 9:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 6:20 [PATCH V4 0/8] Add APSS clock controller support for IPQ6018 Sivaprakash Murugesan
2020-05-04 6:20 ` [PATCH V4 1/8] dt-bindings: mailbox: Add YAML schemas for QCOM APCS global block Sivaprakash Murugesan
2020-05-12 22:46 ` Rob Herring
2020-05-04 6:20 ` [PATCH V4 2/8] dt-bindings: clock: Add schema for QCOM IPQ apss pll Sivaprakash Murugesan
2020-05-12 19:56 ` Bjorn Andersson
2020-05-24 9:49 ` Sivaprakash Murugesan
2020-05-04 6:20 ` [PATCH V4 3/8] clk: qcom: Add ipq apss pll driver Sivaprakash Murugesan
2020-05-04 6:20 ` [PATCH V4 4/8] clk: qcom: Add DT bindings for ipq6018 apss clock controller Sivaprakash Murugesan
2020-05-04 6:20 ` [PATCH V4 5/8] clk: qcom: Add ipq " Sivaprakash Murugesan
2020-05-12 20:12 ` Bjorn Andersson
2020-05-24 9:48 ` Sivaprakash Murugesan
2020-05-04 6:20 ` [PATCH V4 6/8] dt-bindings: mailbox: Add dt-bindings for ipq6018 apcs global block Sivaprakash Murugesan
2020-05-04 6:20 ` [PATCH V4 7/8] mailbox: qcom: Add ipq6018 apcs compatible Sivaprakash Murugesan
2020-05-12 20:19 ` Bjorn Andersson
2020-05-24 9:45 ` Sivaprakash Murugesan [this message]
2020-05-04 6:20 ` [PATCH V4 8/8] arm64: dts: ipq6018: Add a53 pll and apcs clock Sivaprakash Murugesan
2020-05-12 20:24 ` Bjorn Andersson
2020-05-13 3:55 ` Sivaprakash Murugesan
2020-05-18 18:03 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32f33ed2-7c00-3967-e34b-424c5906a91b@codeaurora.org \
--to=sivaprak@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).