From: Jonathan Marek <jonathan@marek.ca>
To: Stephen Boyd <sboyd@kernel.org>, linux-arm-msm@vger.kernel.org
Cc: Rob Herring <robh@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: clock: add QCOM SM8350 display clock bindings
Date: Fri, 4 Jun 2021 13:25:41 -0400 [thread overview]
Message-ID: <56f3b0bd-5dd7-80d4-041a-0fd2daf4b1f2@marek.ca> (raw)
In-Reply-To: <162266925581.4130789.10178141366818328902@swboyd.mtv.corp.google.com>
On 6/2/21 5:27 PM, Stephen Boyd wrote:
> Quoting Jonathan Marek (2021-05-18 17:18:02)
>> Add sm8350 DISPCC bindings, which are simply a symlink to the sm8250
>> bindings. Update the documentation with the new compatible.
>>
>> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> ---
>> .../devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml | 6 ++++--
>> include/dt-bindings/clock/qcom,dispcc-sm8350.h | 1 +
>
>> 2 files changed, 5 insertions(+), 2 deletions(-)
>> create mode 120000 include/dt-bindings/clock/qcom,dispcc-sm8350.h
>
> Why the symlink? Can we have the dt authors use the existing header file
> instead?
>
It would be strange to include bindings with the name of a different
SoC. I guess it is a matter a preference, is there any good reason to
*not* do it like this?
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml
>> index 0cdf53f41f84..8f414642445e 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml
>> @@ -4,24 +4,26 @@
>> $id: http://devicetree.org/schemas/clock/qcom,dispcc-sm8x50.yaml#
>> $schema: http://devicetree.org/meta-schemas/core.yaml#
>>
>> -title: Qualcomm Display Clock & Reset Controller Binding for SM8150/SM8250
>> +title: Qualcomm Display Clock & Reset Controller Binding for SM8150/SM8250/SM8350
>
> Maybe just "Binding for SM8x50 SoCs"
>
Its likely these bindings won't be compatible with future "SM8x50" SoCs,
listing supported SoCs explicitly will avoid confusion in the future.
>>
>> maintainers:
>> - Jonathan Marek <jonathan@marek.ca>
>>
>> description: |
>> Qualcomm display clock control module which supports the clocks, resets and
>> - power domains on SM8150 and SM8250.
>> + power domains on SM8150/SM8250/SM8350.
>
> same 8x50 comment.
>
>>
>> See also:
>> dt-bindings/clock/qcom,dispcc-sm8150.h
>> dt-bindings/clock/qcom,dispcc-sm8250.h
>> + dt-bindings/clock/qcom,dispcc-sm8350.h
>>
>> properties:
>> compatible:
>> enum:
>> - qcom,sm8150-dispcc
>> - qcom,sm8250-dispcc
>> + - qcom,sm8350-dispcc
>>
>> clocks:
>> items:
>> diff --git a/include/dt-bindings/clock/qcom,dispcc-sm8350.h b/include/dt-bindings/clock/qcom,dispcc-sm8350.h
>> new file mode 120000
>> index 000000000000..0312b4544acb
>> --- /dev/null
>> +++ b/include/dt-bindings/clock/qcom,dispcc-sm8350.h
>> @@ -0,0 +1 @@
>> +qcom,dispcc-sm8250.h
>> \ No newline at end of file
next prev parent reply other threads:[~2021-06-04 17:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 0:18 [PATCH v2 1/2] clk: qcom: add support for SM8350 DISPCC Jonathan Marek
2021-05-19 0:18 ` [PATCH v2 2/2] dt-bindings: clock: add QCOM SM8350 display clock bindings Jonathan Marek
2021-06-02 21:27 ` Stephen Boyd
2021-06-04 17:25 ` Jonathan Marek [this message]
2021-06-28 2:39 ` Stephen Boyd
2021-06-06 4:11 ` Bjorn Andersson
2021-06-02 21:34 ` [PATCH v2 1/2] clk: qcom: add support for SM8350 DISPCC Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56f3b0bd-5dd7-80d4-041a-0fd2daf4b1f2@marek.ca \
--to=jonathan@marek.ca \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).