From: Stephen Boyd <swboyd@chromium.org>
To: "James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Pedro Sousa <pedrom.sousa@synopsys.com>
Cc: Andy Gross <agross@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/3] scsi: ufs: Allow resetting the UFS device
Date: Tue, 04 Jun 2019 08:25:14 -0700 [thread overview]
Message-ID: <5cf68d5b.1c69fb81.281cd.5f93@mx.google.com> (raw)
In-Reply-To: <20190604072001.9288-3-bjorn.andersson@linaro.org>
Quoting Bjorn Andersson (2019-06-04 00:20:00)
> @@ -6104,6 +6105,25 @@ static int ufshcd_abort(struct scsi_cmnd *cmd)
> return err;
> }
>
> +/**
> + ufshcd_device_reset() - toggle the (optional) device reset line
> + * @hba: per-adapter instance
> + *
> + * Toggles the (optional) reset line to reset the attached device.
> + */
> +static void ufshcd_device_reset(struct ufs_hba *hba)
> +{
> + /*
> + * The USB device shall detect reset pulses of 1us, sleep for 10us to
This isn't usb though. Can we have a gpio reset driver and then
implement this in the reset framework instead? Or did that not work out
for some reason?
> + * be on the safe side.
> + */
> + gpiod_set_value_cansleep(hba->device_reset, 1);
> + usleep_range(10, 15);
> +
> + gpiod_set_value_cansleep(hba->device_reset, 0);
> + usleep_range(10, 15);
> +}
> +
> /**
> * ufshcd_host_reset_and_restore - reset and restore host controller
> * @hba: per-adapter instance
next prev parent reply other threads:[~2019-06-04 15:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 7:19 [PATCH 0/3] (Qualcomm) UFS device reset support Bjorn Andersson
2019-06-04 7:19 ` [PATCH 1/3] pinctrl: qcom: sdm845: Expose ufs_reset as gpio Bjorn Andersson
2019-06-07 21:26 ` Linus Walleij
2019-06-04 7:20 ` [PATCH 2/3] scsi: ufs: Allow resetting the UFS device Bjorn Andersson
2019-06-04 7:53 ` Marc Gonzalez
2019-06-04 22:14 ` Bjorn Andersson
2019-06-07 10:41 ` Alim Akhtar
2019-06-07 18:27 ` Bjorn Andersson
2019-06-04 8:13 ` [EXT] " Bean Huo (beanhuo)
2019-06-04 18:10 ` John Stultz
2019-06-04 22:30 ` Bjorn Andersson
2019-06-05 21:17 ` Bean Huo (beanhuo)
2019-06-04 15:25 ` Stephen Boyd [this message]
2019-06-04 22:20 ` Bjorn Andersson
2019-06-04 7:20 ` [PATCH 3/3] arm64: dts: qcom: sdm845-mtp: Specify UFS device-reset GPIO Bjorn Andersson
2019-06-04 16:22 ` Stephen Boyd
2019-06-04 22:09 ` Bjorn Andersson
2019-06-07 22:20 ` Linus Walleij
2019-06-04 22:00 ` [PATCH 0/3] (Qualcomm) UFS device reset support John Stultz
2019-06-05 5:50 ` Avri Altman
2019-06-05 6:01 ` Bjorn Andersson
2019-06-05 9:32 ` Avri Altman
2019-06-06 0:39 ` Bjorn Andersson
2019-06-06 6:32 ` Avri Altman
2019-06-06 7:09 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cf68d5b.1c69fb81.281cd.5f93@mx.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jejb@linux.ibm.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.petersen@oracle.com \
--cc=pedrom.sousa@synopsys.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).