Re: [PATCH v5 0/4] USB: misc: Add onboard_usb_hub driver

From: Michal Simek <michal.simek@xilinx.com>
To: Matthias Kaehlcke <mka@chromium.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>
Cc: <devicetree@vger.kernel.org>, Peter Chen <peter.chen@nxp.com>,
	"Stephen Boyd" <swboyd@chromium.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	"Ravi Chandra Sadineni" <ravisadineni@chromium.org>,
	Bastien Nocera <hadess@hadess.net>,
	<linux-kernel@vger.kernel.org>,
	Douglas Anderson <dianders@chromium.org>,
	<linux-usb@vger.kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Al Cooper <alcooperx@gmail.com>,
	"Alexander A. Klimov" <grandmaster@al2klimov.de>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	"Mathias Nyman" <mathias.nyman@intel.com>,
	<linux-arm-msm@vger.kernel.org>,
	"Michal Simek" <michal.simek@xilinx.com>
Subject: Re: [PATCH v5 0/4] USB: misc: Add onboard_usb_hub driver
Date: Wed, 24 Feb 2021 14:25:12 +0100	[thread overview]
Message-ID: <64179b81-454c-0d26-5413-a8df2e292b05@xilinx.com> (raw)
In-Reply-To: <20210210171040.684659-1-mka@chromium.org>

Hi Matthias,

On 2/10/21 6:10 PM, Matthias Kaehlcke wrote:
> This series adds the onboard_usb_hub_driver, the corresponding
> device tree bindings and creation of onboard_usb_hub platform in
> the xhci-plat driver during probe().
> 
> The main issue the driver addresses is that a USB hub needs to be
> powered before it can be discovered. For discrete onboard hubs (an
> example for such a hub is the Realtek RTS5411) this is often solved
> by supplying the hub with an 'always-on' regulator, which is kind
> of a hack. Some onboard hubs may require further initialization
> steps, like changing the state of a GPIO or enabling a clock, which
> requires even more hacks. This driver creates a platform device
> representing the hub which performs the necessary initialization.
> Currently it only supports switching on a single regulator, support
> for multiple regulators or other actions can be added as needed.
> Different initialization sequences can be supported based on the
> compatible string.
> 
> Besides performing the initialization the driver can be configured
> to power the hub off during system suspend. This can help to extend
> battery life on battery powered devices which have no requirements
> to keep the hub powered during suspend. The driver can also be
> configured to leave the hub powered when a wakeup capable USB device
> is connected when suspending, and power it off otherwise.
> 

Rob pointed me here at your series.
http://lore.kernel.org/r/CAL_JsqJedhX6typpUKbnzV7CLK6UZVjq3CyG9iY_j5DLPqvVdw@mail.gmail.com

And I have looked at RTS5411 datasheet and it looks very similar to
Microchip usb5744 chip we use.
Both have i2c/smbus and spi interfaces and also input clock.
usb5744 has also external gpio reset.

There are also usb3503 and others which should fit to this generic DT
binding.

Thanks,
Michal

That's why please keep me in the loop on v6 because I think