From: Chris Lew <quic_clew@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-remoteproc@vger.kernel.org>,
Johan Hovold <johan+linaro@kernel.org>,
Xilin Wu <wuxilin123@gmail.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Subject: Re: [PATCH v7 5/6] soc: qcom: add pd-mapper implementation
Date: Fri, 26 Apr 2024 16:25:29 -0700 [thread overview]
Message-ID: <6b6298c4-485d-ebe5-fa8d-9edc461467a0@quicinc.com> (raw)
In-Reply-To: <20240424-qcom-pd-mapper-v7-5-05f7fc646e0f@linaro.org>
On 4/24/2024 2:28 AM, Dmitry Baryshkov wrote:
> +static int qcom_pdm_start(void)
> +{
> + const struct of_device_id *match;
> + const struct qcom_pdm_domain_data * const *domains;
> + struct device_node *root;
> + int ret, i;
> +
> + root = of_find_node_by_path("/");
> + if (!root)
> + return -ENODEV;
> +
> + match = of_match_node(qcom_pdm_domains, root);
> + of_node_put(root);
> + if (!match) {
> + pr_notice("PDM: no support for the platform, userspace daemon might be required.\n");
> + return -ENODEV;
> + }
> +
> + domains = match->data;
> + if (!domains) {
> + pr_debug("PDM: no domains\n");
> + return -ENODEV;
> + }
> +
> + mutex_lock(&qcom_pdm_mutex);
> + for (i = 0; domains[i]; i++) {
> + ret = qcom_pdm_add_domain(domains[i]);
> + if (ret)
> + goto free_domains;
> + }
> +
> + ret = qmi_handle_init(&qcom_pdm_handle, 1024,
> + NULL, qcom_pdm_msg_handlers);
1024 here seems arbitrary, I think most other usage of qmi_handle_init
has a macro defined for the max message length of the qmi service.
> + if (ret)
> + goto free_domains;
> +
> + ret = qmi_add_server(&qcom_pdm_handle, SERVREG_LOCATOR_SERVICE,
> + SERVREG_QMI_VERSION, SERVREG_QMI_INSTANCE);
> + if (ret) {
> + pr_err("PDM: error adding server %d\n", ret);
> + goto release_handle;
> + }
> + mutex_unlock(&qcom_pdm_mutex);
> +
> + return 0;
> +
> +release_handle:
> + qmi_handle_release(&qcom_pdm_handle);
> +
> +free_domains:
> + qcom_pdm_free_domains();
> + mutex_unlock(&qcom_pdm_mutex);
> +
> + return ret;
> +}
> +
> +static void qcom_pdm_stop(void)
> +{
> + qmi_del_server(&qcom_pdm_handle, SERVREG_LOCATOR_SERVICE,
> + SERVREG_QMI_VERSION, SERVREG_QMI_INSTANCE);
> +
> + qmi_handle_release(&qcom_pdm_handle);
> +
I don't think doing an explicit qmi_del_server() is necessary. As part
of the qmi_handle_release(), the qrtr socket will be closed and the qrtr
ns will broadcast a DEL_SERVER and DEL_CLIENT notification as part of
the cleanup.
> + qcom_pdm_free_domains();
> +}
> +
next prev parent reply other threads:[~2024-04-26 23:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 9:27 [PATCH v7 0/6] soc: qcom: add in-kernel pd-mapper implementation Dmitry Baryshkov
2024-04-24 9:27 ` [PATCH v7 1/6] soc: qcom: pdr: protect locator_addr with the main mutex Dmitry Baryshkov
2024-04-25 19:30 ` Chris Lew
2024-04-24 9:27 ` [PATCH v7 2/6] soc: qcom: pdr: fix parsing of domains lists Dmitry Baryshkov
2024-04-24 9:27 ` [PATCH v7 3/6] soc: qcom: pdr: extract PDR message marshalling data Dmitry Baryshkov
2024-04-24 9:28 ` [PATCH v7 4/6] soc: qcom: qmi: add a way to remove running service Dmitry Baryshkov
2024-04-25 20:57 ` Chris Lew
2024-04-24 9:28 ` [PATCH v7 5/6] soc: qcom: add pd-mapper implementation Dmitry Baryshkov
2024-04-26 13:48 ` Alexey Minnekhanov
2024-04-26 23:25 ` Chris Lew [this message]
2024-04-24 9:28 ` [PATCH v7 6/6] remoteproc: qcom: enable in-kernel PD mapper Dmitry Baryshkov
2024-04-27 1:03 ` Chris Lew
2024-04-27 1:36 ` Dmitry Baryshkov
2024-04-30 19:10 ` Chris Lew
2024-04-25 7:08 ` [PATCH v7 0/6] soc: qcom: add in-kernel pd-mapper implementation Steev Klimaszewski
2024-04-25 7:10 ` Dmitry Baryshkov
2024-04-26 14:02 ` Alexey Minnekhanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b6298c4-485d-ebe5-fa8d-9edc461467a0@quicinc.com \
--to=quic_clew@quicinc.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=quic_sibis@quicinc.com \
--cc=wuxilin123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).