From: Prasad Malisetty <pmaliset@codeaurora.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: agross@kernel.org, bhelgaas@google.com,
bjorn.andersson@linaro.org, lorenzo.pieralisi@arm.com,
robh+dt@kernel.org, svarbanov@mm-sol.com,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
dianders@chromium.org, mka@chromium.org, vbadigan@codeaurora.org,
sallenki@codeaurora.org
Subject: Re: [PATCH v4 3/4] arm64: dts: qcom: sc7280: Add PCIe nodes for IDP board
Date: Tue, 20 Jul 2021 12:27:11 +0530 [thread overview]
Message-ID: <78599ad26dc593273fbe59ac6cb529fc@codeaurora.org> (raw)
In-Reply-To: <CAE-0n50OEX7gMw_q3wL6HH38G1a-hi10D0_dmjJLyKq9ChA5iA@mail.gmail.com>
On 2021-07-17 01:02, Stephen Boyd wrote:
> Quoting Prasad Malisetty (2021-07-16 06:58:46)
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
>> b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
>> index 3900cfc..8f12b8c 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
>> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
>> @@ -268,6 +268,44 @@
>> };
>
> Is this pmk8350_vadc? 'pc' comes before 'pm' so please sort this
> section
> alphabetically on node name.
>
>> };
Agree, we will incorporate the change in next version.
>>
>> +&pcie1 {
>> + status = "okay";
>> +
>> + vdda-supply = <&vreg_l10c_0p8>;
>> +};
>> +
>> +&pcie1_phy {
>> + status = "okay";
>> +
>> + vdda-phy-supply = <&vreg_l10c_0p8>;
>> + vdda-pll-supply = <&vreg_l6b_1p2>;
>> +};
next prev parent reply other threads:[~2021-07-20 6:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 13:58 [PATCH v4 0/4] Add DT bindings and DT nodes for PCIe and PHY in SC7280 Prasad Malisetty
2021-07-16 13:58 ` [PATCH v4 1/4] dt-bindings: pci: qcom: Document PCIe bindings for SC720 Prasad Malisetty
2021-07-16 19:27 ` Stephen Boyd
2021-07-20 6:56 ` Prasad Malisetty
2021-07-16 13:58 ` [PATCH v4 2/4] arm64: dts: qcom: sc7280: Add PCIe and PHY related nodes Prasad Malisetty
2021-07-16 19:31 ` Stephen Boyd
2021-07-20 6:54 ` Prasad Malisetty
2021-08-02 19:23 ` Matthias Kaehlcke
2021-08-17 8:05 ` Prasad Malisetty
2021-07-16 13:58 ` [PATCH v4 3/4] arm64: dts: qcom: sc7280: Add PCIe nodes for IDP board Prasad Malisetty
2021-07-16 19:32 ` Stephen Boyd
2021-07-20 6:57 ` Prasad Malisetty [this message]
2021-07-16 13:58 ` [PATCH v4 4/4] PCIe: qcom: Add support to control pipe clk src Prasad Malisetty
2021-07-16 15:06 ` Bjorn Helgaas
2021-07-16 20:38 ` Bjorn Andersson
2021-07-20 11:28 ` Prasad Malisetty
2021-08-09 17:09 ` Prasad Malisetty
2021-07-16 19:37 ` Stephen Boyd
2021-07-16 20:31 ` Bjorn Andersson
2021-07-16 21:39 ` Stephen Boyd
2021-07-16 22:11 ` Bjorn Andersson
2021-07-16 14:29 ` [PATCH v4 0/4] Add DT bindings and DT nodes for PCIe and PHY in SC7280 Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78599ad26dc593273fbe59ac6cb529fc@codeaurora.org \
--to=pmaliset@codeaurora.org \
--cc=agross@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=sallenki@codeaurora.org \
--cc=svarbanov@mm-sol.com \
--cc=swboyd@chromium.org \
--cc=vbadigan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).