From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Iskren Chernev <iskren.chernev@gmail.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v4 2/2] drivers: qcom: pinctrl: Add pinctrl driver for sm6115
Date: Sat, 26 Jun 2021 01:39:35 +0200 [thread overview]
Message-ID: <7d5d0ed5-bf5b-2a10-b6ad-fc6d16791ea8@somainline.org> (raw)
In-Reply-To: <20210625102147.51162-3-iskren.chernev@gmail.com>
> +
> +static const struct of_device_id sm6115_tlmm_of_match[] = {
> + { .compatible = "qcom,sm4250-tlmm", },
> + { .compatible = "qcom,sm6115-tlmm", },
> + { }
> +};
>
Please do not add separate compatibles for 2 speedbins of the otherwise same SoC.
Otherwise, the driver looks very good.
Konrad
next prev parent reply other threads:[~2021-06-25 23:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 10:21 [PATCH v4 0/2] Add Pinctrl for SM4250 and SM6115 Iskren Chernev
2021-06-25 10:21 ` [PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add SM6115 pinctrl bindings Iskren Chernev
2021-06-25 23:42 ` Bjorn Andersson
2021-06-25 10:21 ` [PATCH v4 2/2] drivers: qcom: pinctrl: Add pinctrl driver for sm6115 Iskren Chernev
2021-06-25 23:39 ` Konrad Dybcio [this message]
2021-06-25 23:44 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d5d0ed5-bf5b-2a10-b6ad-fc6d16791ea8@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=iskren.chernev@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).