From: Jeffrey Hugo <quic_jhugo@quicinc.com>
To: Marc Gonzalez <mgonzalez@freebox.fr>,
Bjorn Andersson <andersson@kernel.org>,
Bryan O Donoghue <bryan.odonoghue@linaro.org>
Cc: MSM <linux-arm-msm@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Douglas Anderson <dianders@chromium.org>,
Pierre-Hugues Husson <phhusson@freebox.fr>,
Arnaud Vrac <avrac@freebox.fr>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH v3] clk: qcom: mmcc-msm8998: fix venus clock issue
Date: Fri, 26 Apr 2024 15:00:45 -0600 [thread overview]
Message-ID: <7e77dd40-40e0-1a65-cf80-5e9ba6f584cd@quicinc.com> (raw)
In-Reply-To: <ff4e2e34-a677-4c39-8c29-83655c5512ae@freebox.fr>
On 4/25/2024 9:07 AM, Marc Gonzalez wrote:
> Right now, msm8998 video decoder (venus) is non-functional:
>
> $ time mpv --hwdec=v4l2m2m-copy --vd-lavc-software-fallback=no --vo=null --no-audio --untimed --length=30 --quiet demo-480.webm
> (+) Video --vid=1 (*) (vp9 854x480 29.970fps)
> Audio --aid=1 --alang=eng (*) (opus 2ch 48000Hz)
> [ffmpeg/video] vp9_v4l2m2m: output VIDIOC_REQBUFS failed: Connection timed out
> [ffmpeg/video] vp9_v4l2m2m: no v4l2 output context's buffers
> [ffmpeg/video] vp9_v4l2m2m: can't configure decoder
> Could not open codec.
> Software decoding fallback is disabled.
> Exiting... (Quit)
>
> Bryan O'Donoghue suggested the proper fix:
> - Set required register offsets in venus GDSC structs.
> - Set HW_CTRL flag.
>
> $ time mpv --hwdec=v4l2m2m-copy --vd-lavc-software-fallback=no --vo=null --no-audio --untimed --length=30 --quiet demo-480.webm
> (+) Video --vid=1 (*) (vp9 854x480 29.970fps)
> Audio --aid=1 --alang=eng (*) (opus 2ch 48000Hz)
> [ffmpeg/video] vp9_v4l2m2m: VIDIOC_G_FMT ioctl
> [ffmpeg/video] vp9_v4l2m2m: VIDIOC_G_FMT ioctl
> ...
> Using hardware decoding (v4l2m2m-copy).
> VO: [null] 854x480 nv12
> Exiting... (End of file)
> real 0m3.315s
> user 0m1.277s
> sys 0m0.453s
>
> NOTES:
>
> GDSC = Globally Distributed Switch Controller
>
> Use same code as mmcc-msm8996 with:
> s/venus_gdsc/video_top_gdsc/
> s/venus_core0_gdsc/video_subcore0_gdsc/
> s/venus_core1_gdsc/video_subcore1_gdsc/
>
> https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/caf_migration/kernel.lnx.4.4.r38-rel/include/dt-bindings/clock/msm-clocks-hwio-8996.h
> https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/caf_migration/kernel.lnx.4.4.r38-rel/include/dt-bindings/clock/msm-clocks-hwio-8998.h
>
> 0x1024 = MMSS_VIDEO GDSCR (undocumented)
> 0x1028 = MMSS_VIDEO_CORE_CBCR
> 0x1030 = MMSS_VIDEO_AHB_CBCR
> 0x1034 = MMSS_VIDEO_AXI_CBCR
> 0x1038 = MMSS_VIDEO_MAXI_CBCR
> 0x1040 = MMSS_VIDEO_SUBCORE0 GDSCR (undocumented)
> 0x1044 = MMSS_VIDEO_SUBCORE1 GDSCR (undocumented)
> 0x1048 = MMSS_VIDEO_SUBCORE0_CBCR
> 0x104c = MMSS_VIDEO_SUBCORE1_CBCR
>
> Fixes: d14b15b5931c2b ("clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver")
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
next prev parent reply other threads:[~2024-04-26 21:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 15:07 [PATCH v3] clk: qcom: mmcc-msm8998: fix venus clock issue Marc Gonzalez
2024-04-26 21:00 ` Jeffrey Hugo [this message]
2024-04-27 19:34 ` Bjorn Andersson
2024-04-29 13:45 ` Marc Gonzalez
2024-04-29 14:39 ` Bryan O'Donoghue
2024-04-29 14:52 ` Konrad Dybcio
2024-04-29 15:04 ` Bryan O'Donoghue
2024-04-30 10:00 ` Konrad Dybcio
2024-04-30 10:04 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e77dd40-40e0-1a65-cf80-5e9ba6f584cd@quicinc.com \
--to=quic_jhugo@quicinc.com \
--cc=andersson@kernel.org \
--cc=avrac@freebox.fr \
--cc=bryan.odonoghue@linaro.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mgonzalez@freebox.fr \
--cc=mturquette@baylibre.com \
--cc=phhusson@freebox.fr \
--cc=quic_vgarodia@quicinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).