From: Felipe Balbi <balbi@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
"open list:DRM DRIVER FOR MSM ADRENO GPU"
<linux-arm-msm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Caleb Connolly <caleb@connolly.tech>,
Felipe Balbi <felipe.balbi@microsoft.com>
Subject: Re: [PATCH] arm64: boot: dts: qcom: sm8150: add SPI nodes
Date: Thu, 15 Apr 2021 14:30:52 +0300 [thread overview]
Message-ID: <878s5jokcz.fsf@kernel.org> (raw)
In-Reply-To: <CAA8EJprdHtxdXCd9dxOi4ZNGoE1r+O9Man6pXJWib+Rrpp9_-g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]
Dmitry Baryshkov <dmitry.baryshkov@linaro.org> writes:
> On Thu, 15 Apr 2021 at 14:02, Felipe Balbi <balbi@kernel.org> wrote:
>>
>> Dmitry Baryshkov <dmitry.baryshkov@linaro.org> writes:
>>
>> > On Thu, 15 Apr 2021 at 13:39, Felipe Balbi <balbi@kernel.org> wrote:
>> >>
>> >> From: Felipe Balbi <felipe.balbi@microsoft.com>
>> >>
>> >> Add missing SPI nodes for SM8150.
>> >>
>> >> Signed-off-by: Felipe Balbi <felipe.balbi@microsoft.com>
>> >
>> > I'd suggest switching to gpio-cs as implemented for sc7180 and sm8250.
>> > At least I'd propose to split the pinctrl into data+clock and CS
>> > configurations, so that the CS implementation can be easily selected
>> > on the board level.
>>
>> I can do that, sure. What do we gain from it, though? The possibility of
>> using more chip selects? It also sounds to me like this could be done as
>> a separate patch.
>
> I'd refer to the original discussion for sc7180:
> https://lore.kernel.org/linux-arm-msm/20200624170746.1.I997a428f58ef9d48b37a27a028360f34e66c00ec@changeid/
Thanks, an interesting discussion indeed. I'll wait for more reviews, if
the rest of folks think we should have the option, I can send an extra
patch or modify $subject. No worries.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
next prev parent reply other threads:[~2021-04-15 11:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 10:38 [PATCH] arm64: boot: dts: qcom: sm8150: add SPI nodes Felipe Balbi
2021-04-15 10:58 ` Dmitry Baryshkov
2021-04-15 11:01 ` Felipe Balbi
2021-04-15 11:22 ` Dmitry Baryshkov
2021-04-15 11:30 ` Felipe Balbi [this message]
2021-12-16 11:13 Felipe Balbi
2021-12-16 13:53 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s5jokcz.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=caleb@connolly.tech \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=felipe.balbi@microsoft.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).