Dmitry Baryshkov <dmitry.baryshkov@linaro.org> writes:

> Hi,
>
> On Thu, 15 Apr 2021 at 13:39, Felipe Balbi <balbi@kernel.org> wrote:
>>
>> From: Felipe Balbi <felipe.balbi@microsoft.com>
>>
>> Add missing SPI nodes for SM8150.
>>
>> Signed-off-by: Felipe Balbi <felipe.balbi@microsoft.com>
>
> I'd suggest switching to gpio-cs as implemented for sc7180 and sm8250.
> At least I'd propose to split the pinctrl into data+clock and CS
> configurations, so that the CS implementation can be easily selected
> on the board level.

I can do that, sure. What do we gain from it, though? The possibility of
using more chip selects? It also sounds to me like this could be done as
a separate patch.

-- 
balbi