From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5575C433ED for ; Thu, 15 Apr 2021 11:22:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 90AEE610E8 for ; Thu, 15 Apr 2021 11:22:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232268AbhDOLXT (ORCPT ); Thu, 15 Apr 2021 07:23:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232130AbhDOLXS (ORCPT ); Thu, 15 Apr 2021 07:23:18 -0400 Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFA17C061574 for ; Thu, 15 Apr 2021 04:22:55 -0700 (PDT) Received: by mail-qv1-xf2f.google.com with SMTP id bs7so10959376qvb.12 for ; Thu, 15 Apr 2021 04:22:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qKjg+Nfd81uXvAszX0KWE5MXxXD8kGWkX2duGPtY7Ag=; b=aI1aNhq2Lu6zSk/zygSPCrcPirMJYGj0PoIxiyk8I22GAwp7gPC5eKd46rze9Mgb2h Dm0hrOMWXVzFtAWnXCt1vrrKipeHuKXmgiDhUBVQlRmM7V77vkxPN22aLl/smKWFm+uT n/GUfiyrITsA556ZlZKvkGEurm3gYTmFOnMQtFUFqce7wORqiHrU6v/9Di+iy0w2Tl1u tuEM1OSPx8ZFYQp/FOEKXNaBmqaiJZ9zVK2+boh5N+K8NbnrVep3OP+edOD/IOIdPySO duUAhAPhGhABPB/l31Z+cbLk9FphNlq2t5rv8Gs8Htj113ygrvDceI5hHjSx9bjvms62 WDCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qKjg+Nfd81uXvAszX0KWE5MXxXD8kGWkX2duGPtY7Ag=; b=laHGmFlwl2x6/izLXzpsve9svA2KyxDYpJ51U/miH/75GrcLJNRPii0uUXI/qPJPYl NmvoNcHNCK1waF3xlcSJd2CcVczCwIN1Na9Yq4loqM0lJDA2OpFBZVeOekqsC5vk+r7T 4LLF1xHourfyqz5EtSO0qChcLGGYvozTAlWq/llmvjjAOzRlORZImxMmEMAGACMmeBsU zb7fPGXUaQuXpF2bAqiIEKcxa2L/LYzmonCmQO0Adm2yg2gabEEcubKrdV2p6NVNKUcO a8orBK/V5LjwRHIDghXl5bXz4s2Inhy2sN+Z4OHn1BWPpDUMpQVHs/S0FW5qr4epv9gg NaQA== X-Gm-Message-State: AOAM532lfyU6HERB0qD930VJUQi4iKSvq22CR8fWfklE3iAvheW+mIn5 bZvOLtFZ5ujpaNG6DjPnMhbDRusr/SpnZ0MUnhq81Q== X-Google-Smtp-Source: ABdhPJw/g5Mp+Nw9Kn8kT37sc0x2C9ZOd45OaIWYMrTgUAE3a15NO43HBegd82GAIK0IW7DBjc9JUBqpxCRWp/izJ/Q= X-Received: by 2002:a05:6214:204:: with SMTP id i4mr2517433qvt.47.1618485775043; Thu, 15 Apr 2021 04:22:55 -0700 (PDT) MIME-Version: 1.0 References: <20210415103854.1810788-1-balbi@kernel.org> <87blafolp5.fsf@kernel.org> In-Reply-To: <87blafolp5.fsf@kernel.org> From: Dmitry Baryshkov Date: Thu, 15 Apr 2021 14:22:43 +0300 Message-ID: Subject: Re: [PATCH] arm64: boot: dts: qcom: sm8150: add SPI nodes To: Felipe Balbi Cc: Andy Gross , Bjorn Andersson , Rob Herring , "open list:DRM DRIVER FOR MSM ADRENO GPU" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Caleb Connolly , Felipe Balbi Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, 15 Apr 2021 at 14:02, Felipe Balbi wrote: > > Dmitry Baryshkov writes: > > > On Thu, 15 Apr 2021 at 13:39, Felipe Balbi wrote: > >> > >> From: Felipe Balbi > >> > >> Add missing SPI nodes for SM8150. > >> > >> Signed-off-by: Felipe Balbi > > > > I'd suggest switching to gpio-cs as implemented for sc7180 and sm8250. > > At least I'd propose to split the pinctrl into data+clock and CS > > configurations, so that the CS implementation can be easily selected > > on the board level. > > I can do that, sure. What do we gain from it, though? The possibility of > using more chip selects? It also sounds to me like this could be done as > a separate patch. I'd refer to the original discussion for sc7180: https://lore.kernel.org/linux-arm-msm/20200624170746.1.I997a428f58ef9d48b37a27a028360f34e66c00ec@changeid/ -- With best wishes Dmitry