From: Doug Anderson <dianders@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Judy Hsiao <judyhsiao@chromium.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Rohit kumar <rohitkr@codeaurora.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH] arm64: dts: qcom: Add wakeup delay for adau codec
Date: Thu, 20 May 2021 14:40:13 -0700 [thread overview]
Message-ID: <CAD=FV=Uzg+a6ZrinAnq_=29103JPs0=oWTa3VkfTUbPRkvGyjw@mail.gmail.com> (raw)
In-Reply-To: <CAE-0n51jjHWSFiip-utVKjAQbaJuj+oKq0GPLgw2q2mG_9B=eg@mail.gmail.com>
Hi,
On Mon, May 17, 2021 at 3:44 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Srinivasa Rao Mandadapu (2021-05-13 05:24:29)
> > Add wakeup delay for fixing PoP noise during capture begin.
> >
> > Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> > Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
> > ---
> > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
> > index 4c6e433c8226..3eb8550da1fc 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
> > @@ -23,6 +23,7 @@ / {
> > adau7002: audio-codec-1 {
> > compatible = "adi,adau7002";
> > IOVDD-supply = <&pp1800_l15a>;
> > + wakeup-delay-ms = <15>;
>
> Is this part of the binding?
It doesn't seem to be, but it's supported by the code. It's also in
the generic "dmic" bindings. The bindings are pre-yaml. Seems like
someone needs to take charge and clean those up, but I'm not sure we
need to block this patch on it?
Though I'm not an expert on audio stuff, assuming that this works OK
I'm fine with:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
-Doug
prev parent reply other threads:[~2021-05-20 21:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 12:24 [PATCH] arm64: dts: qcom: Add wakeup delay for adau codec Srinivasa Rao Mandadapu
2021-05-17 22:44 ` Stephen Boyd
2021-05-20 21:40 ` Doug Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=Uzg+a6ZrinAnq_=29103JPs0=oWTa3VkfTUbPRkvGyjw@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=judyhsiao@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=srivasam@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).