From: Doug Anderson <dianders@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>
Subject: Re: [PATCH] arm64: dts: qcom: Disable PON on Trogdor
Date: Wed, 2 Jun 2021 09:59:00 -0700 [thread overview]
Message-ID: <CAD=FV=X52FyU7F4itVjegwTdX9L40Qpb33sdSvi_=McH4KxVrA@mail.gmail.com> (raw)
In-Reply-To: <20210601184417.3020834-1-swboyd@chromium.org>
Hi,
On Tue, Jun 1, 2021 at 11:44 AM Stephen Boyd <swboyd@chromium.org> wrote:
>
> We don't use the PON module on Trogdor devices. Instead the reboot
> reason is sort of stored in the 'eventlog' and the bootloader figures
> out if the boot is abnormal and records that there. Disable the PON node
> and then drop the power key disabling because that's a child node that
> will no longer be enabled if the PON node is disabled.
>
> Cc: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Right. So essentially you're saying that the bootloader on trogdor
(coreboot / depthcharge) doesn't do anything with this and thus it
doesn't make sense on this board. That sounds right to me. Basically
there's no way in userspace to tell the bootloader to reboot into
recovery mode or developer mode. Those things need to be initiated
manually by the user.
It's possible that Qualcomm internally has some out-of-tree patches
where they use the PON for ramdump mode. +Rajendra as an FYI in case
there's somehow he should give a heads up to about this.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
next prev parent reply other threads:[~2021-06-02 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 18:44 [PATCH] arm64: dts: qcom: Disable PON on Trogdor Stephen Boyd
2021-06-02 16:59 ` Doug Anderson [this message]
2021-06-10 14:50 ` patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=X52FyU7F4itVjegwTdX9L40Qpb33sdSvi_=McH4KxVrA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rnayak@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).