From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21693C2B9F8 for ; Tue, 25 May 2021 17:20:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F202661401 for ; Tue, 25 May 2021 17:20:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233726AbhEYRVd (ORCPT ); Tue, 25 May 2021 13:21:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233698AbhEYRVN (ORCPT ); Tue, 25 May 2021 13:21:13 -0400 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9B42C06138D for ; Tue, 25 May 2021 10:19:30 -0700 (PDT) Received: by mail-qk1-x72c.google.com with SMTP id q10so31181621qkc.5 for ; Tue, 25 May 2021 10:19:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0I/7mJjy8fAtyuQW3u9pKYduA4z2KSC8v2zpf0k2q4Q=; b=LoEAi62rRu7tHFsRIAnERe0Uo6+lB7bp00VbsoFCad2BNA4J/p4XQRSUgdI2W2YwpI BCwReshEWdDvXBR49YxtAe1g92O1OceM2w/LWlaEzlpySS/rDNROaMb5tLKesjeJPP0X CNKYpCq57mgvBz5whA92hLzX7uNngLYIcuAIs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0I/7mJjy8fAtyuQW3u9pKYduA4z2KSC8v2zpf0k2q4Q=; b=pJVqmhYXzF0188TILh+qf1l5JlJJZs0D9EMlt37xc45ZacxXG0o1o9JnoYe/BrsTA7 2AxYfPFRPs9r75gFgfuK4qEKZFaVvrcrq5DnxPvvIq+vR+WNU1zY2VhBGDDVXmJ5Xxwi UT+9I0ZmY3u9dFo8dUCzWqg4zI1bRzlZwEzwijvU/PkIXi0/8EDxVHPvY6v+aU6KyAHJ LwHSocsvpZUdHph1e4gc5gzAO3rwo5BZ9UTuaym/Hw10b2fisCrdrPCXlpNfPf1yYwmF /TUdNhDiRfDnai8ksTyhQHYzSA7FZiN3IDSjB0zIf3qXYEE67VwwVv6KEeZJpohFz1GW 52jA== X-Gm-Message-State: AOAM532PPIniL2jWvw4XuSpB5c+/Yicv/2uApl98qwyqTx1Y5fFdupzu ONoWUOID5P9o4JmznUv3dsKWTVB/zunsFg== X-Google-Smtp-Source: ABdhPJx1fNUb+ecuxPwmRmKWEJOenQ5ekTJFSZwXprW0Jan30q1ij47PKYoYXKTlnsiMb1xrziT5xQ== X-Received: by 2002:ae9:eb12:: with SMTP id b18mr23738220qkg.459.1621963169894; Tue, 25 May 2021 10:19:29 -0700 (PDT) Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com. [209.85.219.171]) by smtp.gmail.com with ESMTPSA id j16sm12689495qtr.27.2021.05.25.10.19.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 May 2021 10:19:29 -0700 (PDT) Received: by mail-yb1-f171.google.com with SMTP id y197so2387069ybe.11 for ; Tue, 25 May 2021 10:19:29 -0700 (PDT) X-Received: by 2002:a5b:54a:: with SMTP id r10mr44274582ybp.476.1621963168291; Tue, 25 May 2021 10:19:28 -0700 (PDT) MIME-Version: 1.0 References: <1621927831-29471-1-git-send-email-rajeevny@codeaurora.org> <1621927831-29471-5-git-send-email-rajeevny@codeaurora.org> In-Reply-To: <1621927831-29471-5-git-send-email-rajeevny@codeaurora.org> From: Doug Anderson Date: Tue, 25 May 2021 10:19:15 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v4 4/4] drm/panel-simple: Add Samsung ATNA33XC20 To: Rajeev Nandan Cc: y@qualcomm.com, dri-devel , linux-arm-msm , freedreno , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Thierry Reding , Sam Ravnborg , Rob Clark , Lyude Paul , Jani Nikula , Rob Herring , Laurent Pinchart , Andrzej Hajda , Daniel Thompson , "Kristian H. Kristensen" , Abhinav Kumar , Sean Paul , Kalyan Thota , mkrishn@codeaurora.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Tue, May 25, 2021 at 12:31 AM Rajeev Nandan wrote: > > Add Samsung 13.3" FHD eDP AMOLED panel. > > Signed-off-by: Rajeev Nandan > --- > > Changes in v4: > - New > > drivers/gpu/drm/panel/panel-simple.c | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index caed71b..21af794 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -3644,6 +3644,37 @@ static const struct panel_desc rocktech_rk101ii01d_ct = { > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > > +static const struct drm_display_mode samsung_atna33xc20_mode = { > + .clock = 138770, > + .hdisplay = 1920, > + .hsync_start = 1920 + 48, > + .hsync_end = 1920 + 48 + 32, > + .htotal = 1920 + 48 + 32 + 80, > + .vdisplay = 1080, > + .vsync_start = 1080 + 8, > + .vsync_end = 1080 + 8 + 8, > + .vtotal = 1080 + 8 + 8 + 16, > + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC, > +}; > + > +static const struct panel_desc samsung_atna33xc20 = { > + .modes = &samsung_atna33xc20_mode, > + .num_modes = 1, > + .bpc = 10, > + .size = { > + .width = 294, > + .height = 165, > + }, > + .delay = { > + .disable_to_power_off = 150, > + .power_to_enable = 150, > + .hpd_absent_delay = 200, > + .unprepare = 500, > + }, > + .connector_type = DRM_MODE_CONNECTOR_eDP, > + .uses_dpcd_backlight = true, >From my feedback on the previous patch in this series, I believe the "uses_dpcd_backlight" property should be removed and this should be auto-detected. Other than that this patch looks fine to me. Feel free to add my Reviewed-by tag next spin when that property is removed.