From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F87FC4332F for ; Tue, 5 Oct 2021 01:13:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6E136124D for ; Tue, 5 Oct 2021 01:13:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229549AbhJEBPT (ORCPT ); Mon, 4 Oct 2021 21:15:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229813AbhJEBPS (ORCPT ); Mon, 4 Oct 2021 21:15:18 -0400 Received: from mail-oo1-xc2f.google.com (mail-oo1-xc2f.google.com [IPv6:2607:f8b0:4864:20::c2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8E5AC061753 for ; Mon, 4 Oct 2021 18:13:28 -0700 (PDT) Received: by mail-oo1-xc2f.google.com with SMTP id z11-20020a4ad1ab000000b0029f085f5f64so5939925oor.5 for ; Mon, 04 Oct 2021 18:13:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=/QiyAF8stN6WXJkebMYhEKCk+J6tjZCzO5t5KsxkaW8=; b=Pwmy9PVWT3pIfz5Si5cRGpSEO6knwSKfjSbmckUtWqpjCvAj4Ewq+zy34wQipF5NOP BzEsmNRu/QOV7C0QgcTfv6H/wBxKyfTo/o3vhNXrXI6nZ777vdXbSqjwvkx0raD5xYVS ZbieAVrbTEAhJ40hDVqGATk6csUZ14pz0VIQI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=/QiyAF8stN6WXJkebMYhEKCk+J6tjZCzO5t5KsxkaW8=; b=UFSpCniWYgl/QvnkATh5yuzL3xEnQLY8maplJ32Dua9lPWG/k4DOV5qWEDXpj1VjUZ io1YtjAIWjWADTPqZkqMwszDz3D9l4EuuLSysXga+bR9hQEfBXrpqwpKFE6Z283XE0H8 NeRJVD/YbsLpBK3X931zNqXc8limdoSSVvoGbeTGsHoPe28TAJMftQ91DT5K7RjdGw3B eakkvHWLcOfj78Lk1Uj97W9Ywj/IuoeTjxc5E5+U+gkq7j9J5xtmPy3YR0UJWiiBjO4O Vmt1HX05CqHxDQzDSTN2LgfUcY4w8N+bRjKFjG4v3yZZxtMrVKJuWj0qEHEMBKIMHC6+ 2V/w== X-Gm-Message-State: AOAM530ImJzprQhCMP0i2bzCoOynbJyQrNA0A1k3as7MbycTIxfHPiZi xHwCtA7d9doElB937KN5myD0la9tvlc521V2zSeHPg== X-Google-Smtp-Source: ABdhPJzGa90ACbuF6mgv6oFURLXi+3lJ8M+6w5Brhzs0n9UVBZGhvuUbVVBefiJt5y9Yi2qiXsK00OBN15wA9+TjFYc= X-Received: by 2002:a4a:8508:: with SMTP id k8mr5453028ooh.25.1633396407883; Mon, 04 Oct 2021 18:13:27 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 4 Oct 2021 21:13:27 -0400 MIME-Version: 1.0 In-Reply-To: <1633376488-545-5-git-send-email-pmaliset@codeaurora.org> References: <1633376488-545-1-git-send-email-pmaliset@codeaurora.org> <1633376488-545-5-git-send-email-pmaliset@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Mon, 4 Oct 2021 21:13:27 -0400 Message-ID: Subject: Re: [PATCH v10 4/5] PCI: qcom: Add a flag in match data along with ops To: Prasad Malisetty , agross@kernel.org, bhelgaas@google.com, bjorn.andersson@linaro.org, lorenzo.pieralisi@arm.com, robh+dt@kernel.org, svarbanov@mm-sol.com Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, dianders@chromium.org, mka@chromium.org, vbadigan@codeaurora.org, sallenki@codeaurora.org, manivannan.sadhasivam@linaro.org, linux-pci@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Prasad Malisetty (2021-10-04 12:41:27) > @@ -1488,7 +1528,13 @@ static int qcom_pcie_probe(struct platform_device *pdev) > > pcie->pci = pci; > > - pcie->ops = of_device_get_match_data(dev); > + pcie_cfg = of_device_get_match_data(dev); > + pcie->ops = pcie_cfg->ops; > + if (!pcie->ops) { Sorry I meant check for pcie_cfg being NULL too. of_device_get_match_data() can return NULL if the match doesn't work for some reason. > + dev_err(dev, "Invalid platform data\n"); > + return -EINVAL; > + } > + pcie->pipe_clk_need_muxing = pcie_cfg->pipe_clk_need_muxing; > > pcie->reset = devm_gpiod_get_optional(dev, "perst", GPIOD_OUT_HIGH); > if (IS_ERR(pcie->reset)) {