From: Rob Clark <robdclark@gmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
freedreno <freedreno@lists.freedesktop.org>,
aarch64-laptops@lists.linaro.org,
Rob Clark <robdclark@chromium.org>,
Andrzej Hajda <a.hajda@samsung.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] drm/bridge: ti-sn65dsi86: use helper to lookup panel-id
Date: Sun, 30 Jun 2019 15:04:51 -0700 [thread overview]
Message-ID: <CAF6AEGvJ3FoBxu=EhrHJ96nV-60TTiAwkWb0a5Wsauw-_dtjiw@mail.gmail.com> (raw)
In-Reply-To: <20190630215742.GK7043@pendragon.ideasonboard.com>
On Sun, Jun 30, 2019 at 2:58 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Rob,
>
> On Sun, Jun 30, 2019 at 02:50:59PM -0700, Rob Clark wrote:
> > On Sun, Jun 30, 2019 at 2:17 PM Laurent Pinchart wrote:
> > > On Sun, Jun 30, 2019 at 01:36:08PM -0700, Rob Clark wrote:
> > > > From: Rob Clark <robdclark@chromium.org>
> > > >
> > > > Use the drm_of_find_panel_id() helper to decide which endpoint to use
> > > > when looking up panel. This way we can support devices that have
> > > > multiple possible panels, such as the aarch64 laptops.
> > > >
> > > > Signed-off-by: Rob Clark <robdclark@chromium.org>
> > > > ---
> > > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 5 +++--
> > > > 1 file changed, 3 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > > > index 2719d9c0864b..56c66a43f1a6 100644
> > > > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > > > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > > > @@ -790,7 +790,7 @@ static int ti_sn_bridge_probe(struct i2c_client *client,
> > > > const struct i2c_device_id *id)
> > > > {
> > > > struct ti_sn_bridge *pdata;
> > > > - int ret;
> > > > + int ret, panel_id;
> > > >
> > > > if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
> > > > DRM_ERROR("device doesn't support I2C\n");
> > > > @@ -811,7 +811,8 @@ static int ti_sn_bridge_probe(struct i2c_client *client,
> > > >
> > > > pdata->dev = &client->dev;
> > > >
> > > > - ret = drm_of_find_panel_or_bridge(pdata->dev->of_node, 1, 0,
> > > > + panel_id = drm_of_find_panel_id();
> > > > + ret = drm_of_find_panel_or_bridge(pdata->dev->of_node, 1, panel_id,
> > > > &pdata->panel, NULL);
> > > > if (ret) {
> > > > DRM_ERROR("could not find any panel node\n");
> > >
> > > No, I'm sorry, but that's a no-go. We can't patch every single bridge
> > > driver to support this hack. We need a solution implemented at another
> > > level that will not spread throughout the whole subsystem.
> >
> > it could be possible to make a better helper.. but really there aren't
> > *that* many bridge drivers
> >
> > suggestions ofc welcome, but I think one way or another we are going
> > to need to patch bridges by the time we get to adding ACPI support, so
> > really trivial couple line patches to the handful of bridges we have
> > isn't really something that worries me
>
> It's only one right now as that's the only one you care about, but
> before we'll have time to blink, it will be another one, and another
> one, ... Sorry, that's a no-go for me.
I could ofc add helper call to all the existing bridges.. that seemed
a bit overkill for v1 patchset
BR,
-R
next prev parent reply other threads:[~2019-06-30 22:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-30 20:36 [PATCH 0/4] drm+dt+efi: support devices with multiple possible panels Rob Clark
2019-06-30 20:36 ` [PATCH 1/4] dt-bindings: chosen: document panel-id binding Rob Clark
2019-07-01 14:03 ` Rob Herring
2019-07-01 14:28 ` Jeffrey Hugo
2019-07-01 14:41 ` Rob Clark
2019-11-30 18:37 ` Rob Clark
2019-11-30 18:39 ` Rob Clark
2019-06-30 20:36 ` [PATCH 2/4] efi/libstub: detect panel-id Rob Clark
2019-07-02 20:26 ` Ard Biesheuvel
2019-07-02 20:35 ` Ard Biesheuvel
2019-07-02 21:01 ` Rob Clark
2019-07-02 21:53 ` Ard Biesheuvel
2019-07-02 22:36 ` Rob Clark
2019-07-02 21:59 ` Leif Lindholm
2019-07-02 22:48 ` Rob Clark
2019-07-03 16:33 ` Leif Lindholm
2019-07-03 17:41 ` Rob Clark
2019-07-03 17:54 ` Ard Biesheuvel
2019-06-30 20:36 ` [PATCH 3/4] drm: add helper to lookup panel-id Rob Clark
2019-06-30 20:36 ` [PATCH 4/4] drm/bridge: ti-sn65dsi86: use " Rob Clark
2019-06-30 21:17 ` Laurent Pinchart
2019-06-30 21:50 ` Rob Clark
2019-06-30 21:57 ` Laurent Pinchart
2019-06-30 22:04 ` Rob Clark [this message]
2019-06-30 20:47 ` [PATCH 0/4] drm+dt+efi: support devices with multiple possible panels Laurent Pinchart
2019-06-30 21:05 ` Rob Clark
2019-06-30 21:15 ` Laurent Pinchart
2019-06-30 21:35 ` Rob Clark
2019-07-02 12:50 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF6AEGvJ3FoBxu=EhrHJ96nV-60TTiAwkWb0a5Wsauw-_dtjiw@mail.gmail.com' \
--to=robdclark@gmail.com \
--cc=a.hajda@samsung.com \
--cc=aarch64-laptops@lists.linaro.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).