From: Vivek Gautam <vivek.gautam@codeaurora.org>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc: Andy Gross <agross@kernel.org>, kishon <kishon@ti.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] phy: qualcomm: phy-qcom-qmp: Add of_node_put() before return
Date: Mon, 5 Aug 2019 11:36:41 +0530 [thread overview]
Message-ID: <CAFp+6iE0BN9+BA-9hozs0-0LDCA+-LLZPdZfebaRAi9nTRV4xg@mail.gmail.com> (raw)
In-Reply-To: <20190804162420.6005-1-nishkadg.linux@gmail.com>
On Sun, Aug 4, 2019 at 9:54 PM Nishka Dasgupta <nishkadg.linux@gmail.com> wrote:
>
> Each iteration of for_each_available_child_of_node puts the previous
> node, but in the case of a return from the middle of the loop, there is
> no put, thus causing a memory leak. Hence add an of_node_put before the
> return in two places.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
> index 34ff6434da8f..2f0652efebf0 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> @@ -2094,6 +2094,7 @@ static int qcom_qmp_phy_probe(struct platform_device *pdev)
> dev_err(dev, "failed to create lane%d phy, %d\n",
> id, ret);
> pm_runtime_disable(dev);
> + of_node_put(child);
> return ret;
> }
>
> @@ -2106,6 +2107,7 @@ static int qcom_qmp_phy_probe(struct platform_device *pdev)
> dev_err(qmp->dev,
> "failed to register pipe clock source\n");
> pm_runtime_disable(dev);
> + of_node_put(child);
Nice find. Thanks for the patch.
Reviewed-by: Vivek Gautam <vivek.gautam@codeaurora.org>
Best regards
Vivek
[snip]
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2019-08-05 6:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-04 16:24 [PATCH] phy: qualcomm: phy-qcom-qmp: Add of_node_put() before return Nishka Dasgupta
2019-08-05 6:06 ` Vivek Gautam [this message]
2019-08-05 12:11 ` Markus Elfring
2019-08-08 7:16 Nishka Dasgupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFp+6iE0BN9+BA-9hozs0-0LDCA+-LLZPdZfebaRAi9nTRV4xg@mail.gmail.com \
--to=vivek.gautam@codeaurora.org \
--cc=agross@kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nishkadg.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).