From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0013C43461 for ; Tue, 15 Sep 2020 12:47:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5A96206A5 for ; Tue, 15 Sep 2020 12:47:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Q1VROlQW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726502AbgIOMrE (ORCPT ); Tue, 15 Sep 2020 08:47:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726477AbgIOMpK (ORCPT ); Tue, 15 Sep 2020 08:45:10 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E214EC06174A for ; Tue, 15 Sep 2020 05:45:09 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id z1so3179807wrt.3 for ; Tue, 15 Sep 2020 05:45:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=prgbbLEwgblX++DIA6lSNe0xZAiKfHZki6I+StVAnLE=; b=Q1VROlQWfmlbZeeOVVji/0iVuQbrzHv3LyXlzJKB/jZyIl7jlwtq83iMQNIuBTtIDU mMJrv6XDPjLmOFIIlreqHabqlek6mVxO/yH3LCwl6pXubX3sxPWzQx+BTKkXXjULprxE a9hVqPQTocex/KOq6CV5LbnS1W7amLkZEXuFg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=prgbbLEwgblX++DIA6lSNe0xZAiKfHZki6I+StVAnLE=; b=i+qD4zufQGbDvzz861CGjLw3An8JtnzlLmsyO+rRAFc6FERL3VItkpf5EKMgNPMZH0 StFx6ph7lqIVNEWZE68Xd6tbqmM9P6V8DelV5jtAB/I64ch/LEkFDoZeN9aDH0s8kmf/ bxSa4xVrXmiMLnWAwhLmdRIArrVYQ1am9K1CVVWx5DxEMdur9ql3i0fupi0FoWYRiX1J D1vFc8Yltay9q4nO065LoexlL2VdjBWOSnK9RDRmfelFVL+SRIi6MNjM12VdKcicb3PK Rs+g88w7WUnxUeXKit0TKQ6bElNYwpHpLg+9A8V1lO3mfePNapbZ7KIXn+Egsmf6A0xn 8hRw== X-Gm-Message-State: AOAM533yfY+62w+UdwmEEKjd1bWU+AGe9mAmGhD3voEvvaPSESXtnGWF 35Hti9HZmEGC4iXHvTxZ+gkBjVZED3WA2weuKoLvBA== X-Google-Smtp-Source: ABdhPJywvAYnO/cUJA6n7jjsXdnAk2rhTKdrXd0MShhk2rxfYd1+ycLgavEuhL4DeOkvtc7FxftmCne4Gau4Rvcai7s= X-Received: by 2002:a5d:510d:: with SMTP id s13mr21605335wrt.177.1600173908051; Tue, 15 Sep 2020 05:45:08 -0700 (PDT) MIME-Version: 1.0 References: <20200914080619.4178587-1-cychiang@chromium.org> <20200914080619.4178587-3-cychiang@chromium.org> <20200914174812.GA4125843@bogus> In-Reply-To: <20200914174812.GA4125843@bogus> From: Cheng-yi Chiang Date: Tue, 15 Sep 2020 20:44:37 +0800 Message-ID: Subject: Re: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings To: Rob Herring Cc: linux-kernel , Dylan Reid , Bjorn Andersson , Takashi Iwai , "open list:ARM/Rockchip SoC..." , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Patrick Lai , Tzung-Bi Shih , Linux ARM , Mark Brown , Srinivasa Rao , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Heiko Stuebner , linux-arm-msm , Matthias Brugger , Stephan Gerhold , Doug Anderson , Banajit Goswami , Liam Girdwood , Rohit kumar , Andy Gross , "moderated list:ARM/Mediatek SoC support" , Taniya Das , Srini Kandagatla Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Sep 15, 2020 at 1:48 AM Rob Herring wrote: > > On Mon, 14 Sep 2020 16:06:18 +0800, Cheng-Yi Chiang wrote: > > Add devicetree bindings documentation file for sc7180 sound card. > > > > Signed-off-by: Cheng-Yi Chiang > > --- > > .../bindings/sound/qcom,sc7180.yaml | 130 ++++++++++++++++++ > > 1 file changed, 130 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml > > > > > Please add Acked-by/Reviewed-by tags when posting new versions. However, > there's no need to repost patches *only* to add the tags. The upstream > maintainer will do that for acks received on the version they apply. > > If a tag was not added on purpose, please state why and what changed. > Hi Rob, There was a change between v9 and v10 on compatible string so I did not add your Reviewed-by. Now it is "qcom,sc7180-sndcard-rt5682-m98357-1mic" following Stephan's comment in https://patchwork.kernel.org/comment/23608881/ to make compatible string more specific to board configuration. I only add the note to the cover letter. Sorry the cover letter became too long to follow. I will add the note in patch mail itself for future changes. Thanks for taking a look again.