From: Alexandru M Stan <amstan@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Mark Brown <broonie@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org,
Akash Asthana <akashast@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH] spi: spi-geni-qcom: Use the new method of gpio CS control
Date: Wed, 2 Dec 2020 14:18:20 -0800 [thread overview]
Message-ID: <CAHNYxRwMD4XahHXWW9z7b=VCOEsdPe5Df4CohNwmBy_ijWJ62g@mail.gmail.com> (raw)
In-Reply-To: <20201202214935.1114381-1-swboyd@chromium.org>
On Wed, Dec 2, 2020 at 1:49 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Let's set the 'use_gpio_descriptors' field so that we use the new way of
> requesting the CS GPIOs in the core. This allows us to avoid having to
> configure the CS pins in "output" mode with an 'output-enable' pinctrl
> setting.
>
> Cc: Akash Asthana <akashast@codeaurora.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> Acked-by: Alexandru M Stan <amstan@chromium.org>
I meant this as a joke in chat. It doesn't really mean anything in any capacity.
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> drivers/spi/spi-geni-qcom.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c
> index 25810a7eef10..c4c88984abc9 100644
> --- a/drivers/spi/spi-geni-qcom.c
> +++ b/drivers/spi/spi-geni-qcom.c
> @@ -636,6 +636,7 @@ static int spi_geni_probe(struct platform_device *pdev)
> spi->auto_runtime_pm = true;
> spi->handle_err = handle_fifo_timeout;
> spi->set_cs = spi_geni_set_cs;
> + spi->use_gpio_descriptors = true;
>
> init_completion(&mas->cs_done);
> init_completion(&mas->cancel_done);
>
> base-commit: b65054597872ce3aefbc6a666385eabdf9e288da
> --
> https://chromeos.dev
>
Unfortunately this patch makes my cros-ec (the main EC that used to
work even before my debugging) also fail to probe:
[ 0.839533] cros-ec-spi spi6.0: EC failed to respond in time
[ 1.040453] cros-ec-spi spi6.0: EC failed to respond in time
[ 1.040852] cros-ec-spi spi6.0: Cannot identify the EC: error -110
[ 1.040855] cros-ec-spi spi6.0: cannot register EC, fallback to spidev
[ 1.040942] cros-ec-spi: probe of spi6.0 failed with error -110
I wasn't closely looking at this part closely when I was using my
other spi port with spidev, so this is why I haven't noticed it
before.
Doug suggests this might be a polarity issue. More scoping to be had.
On the other hand my gpioinfo output is better with this patch:
line 86: "AP_SPI_FP_MISO" unused input active-high
line 87: "AP_SPI_FP_MOSI" unused input active-high
line 88: "AP_SPI_FP_CLK" unused input active-high
line 89: "AP_SPI_FP_CS_L" "spi10 CS0" output active-low [used]
Previously they were:
line 86: "AP_SPI_FP_MISO" unused input active-high
line 87: "AP_SPI_FP_MOSI" unused input active-high
line 88: "AP_SPI_FP_CLK" unused input active-high
line 89: "AP_SPI_FP_CS_L" unused output active-high
But I'm still disappointed the rest of the pins (CLK MISO MOSI) are
still "unused", but I was told that's just an artifact of those pins
not being gpios (but remuxed to spi).
Alexandru Stan (amstan)
next prev parent reply other threads:[~2020-12-02 22:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 21:49 [PATCH] spi: spi-geni-qcom: Use the new method of gpio CS control Stephen Boyd
2020-12-02 22:18 ` Alexandru M Stan [this message]
2020-12-02 23:28 ` Stephen Boyd
2020-12-03 0:47 ` Stephen Boyd
2020-12-03 20:06 ` Doug Anderson
2020-12-04 0:10 ` Stephen Boyd
2020-12-04 9:13 ` Enric Balletbo i Serra
2020-12-04 17:00 ` Mark Brown
2020-12-29 20:15 ` patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHNYxRwMD4XahHXWW9z7b=VCOEsdPe5Df4CohNwmBy_ijWJ62g@mail.gmail.com' \
--to=amstan@chromium.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).