From: Mike Leach <mike.leach@linaro.org>
To: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
linux-arm-msm@vger.kernel.org,
Coresight ML <coresight@lists.linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Stephen Boyd <swboyd@chromium.org>
Subject: Re: [PATCHv2 1/4] coresight: replicator: Use CS_AMBA_ID macro for id table
Date: Thu, 21 May 2020 17:14:34 +0100 [thread overview]
Message-ID: <CAJ9a7VjfmkDZikiW2R7jd2aq0Dj-xNgStKLhoOsow_KRV4RH+g@mail.gmail.com> (raw)
In-Reply-To: <063325edbcff869fde60c2af484e009c0b124ae4.1589894597.git.saiprakash.ranjan@codeaurora.org>
On Tue, 19 May 2020 at 14:36, Sai Prakash Ranjan
<saiprakash.ranjan@codeaurora.org> wrote:
>
> Use CS_AMBA_ID macro for dynamic replicator AMBA id table
> instead of open coding.
>
> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> ---
> drivers/hwtracing/coresight/coresight-replicator.c | 13 +++----------
> 1 file changed, 3 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c
> index e7dc1c31d20d..c619b456f55a 100644
> --- a/drivers/hwtracing/coresight/coresight-replicator.c
> +++ b/drivers/hwtracing/coresight/coresight-replicator.c
> @@ -348,16 +348,9 @@ static int dynamic_replicator_probe(struct amba_device *adev,
> }
>
> static const struct amba_id dynamic_replicator_ids[] = {
> - {
> - .id = 0x000bb909,
> - .mask = 0x000fffff,
> - },
> - {
> - /* Coresight SoC-600 */
> - .id = 0x000bb9ec,
> - .mask = 0x000fffff,
> - },
> - { 0, 0 },
> + CS_AMBA_ID(0x000bb909),
> + CS_AMBA_ID(0x000bb9ec), /* Coresight SoC-600 */
> + {},
> };
>
Reviewed by: Mike Leach <mike.leach@linaro.org>
> static struct amba_driver dynamic_replicator_driver = {
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
> _______________________________________________
> CoreSight mailing list
> CoreSight@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/coresight
--
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK
next prev parent reply other threads:[~2020-05-21 16:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 13:35 [PATCHv2 0/4] Add support for replicators which loses context on clock removal Sai Prakash Ranjan
2020-05-19 13:36 ` [PATCHv2 1/4] coresight: replicator: Use CS_AMBA_ID macro for id table Sai Prakash Ranjan
2020-05-21 16:14 ` Mike Leach [this message]
2020-05-19 13:36 ` [PATCHv2 2/4] coresight: catu: " Sai Prakash Ranjan
2020-05-21 16:15 ` Mike Leach
2020-05-19 13:36 ` [PATCHv2 3/4] coresight: replicator: Reset replicator if context is lost Sai Prakash Ranjan
2020-05-21 16:08 ` Mike Leach
2020-05-21 17:03 ` Sai Prakash Ranjan
2020-05-22 17:40 ` Mathieu Poirier
2020-05-22 17:56 ` Sai Prakash Ranjan
2020-05-19 13:36 ` [PATCHv2 4/4] dt-bindings: arm: coresight: Add optional property to replicators Sai Prakash Ranjan
2020-05-21 16:11 ` Mike Leach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ9a7VjfmkDZikiW2R7jd2aq0Dj-xNgStKLhoOsow_KRV4RH+g@mail.gmail.com \
--to=mike.leach@linaro.org \
--cc=coresight@lists.linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=suzuki.poulose@arm.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).