Re: [PATCH v7 1/5] Input: elan_i2c: Export the device id whitelist

[Jeffrey Hugo <jeffrey.l.hugo@gmail.com>]

On Thu, Jun 20, 2019 at 10:34 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> Hi Jeffrey,
>
> On Thu, Jun 20, 2019 at 7:33 AM Jeffrey Hugo <jeffrey.l.hugo@gmail.com> wrote:
> >  #ifdef CONFIG_OF
> > -static const struct of_device_id elan_of_match[] = {
> > -       { .compatible = "elan,ekth3000" },
> > -       { /* sentinel */ }
> > -};
>
> I think OF IDs should stay in this file since we agreed HID will not
> be checking them.

I thought it would be convenient to keep all the IDs in one place, but
I'll put these back.

>
> >  MODULE_DEVICE_TABLE(of, elan_of_match);
> >  #endif
> >
> > diff --git a/include/linux/input/elan-i2c-ids.h b/include/linux/input/elan-i2c-ids.h
> > new file mode 100644
> > index 000000000000..8130bbebbdda
> > --- /dev/null
> > +++ b/include/linux/input/elan-i2c-ids.h
> > @@ -0,0 +1,68 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*
> > + * Elan I2C Touchpad devide whitelist
>
> s/devide/device/

Doh.  Will fix.

>
> > + *
> > + * Copyright (C) 2019 Jeffrey Hugo.  All rights reserved.
>
> This just moves the code around. If anything I'd say it should keep
> the original Elan copyright.

Ok.  No problem.

>
> Thanks.
>
> --
> Dmitry