From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53E84C433ED for ; Fri, 23 Apr 2021 16:12:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1EBAB61463 for ; Fri, 23 Apr 2021 16:12:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229549AbhDWQN2 (ORCPT ); Fri, 23 Apr 2021 12:13:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbhDWQN1 (ORCPT ); Fri, 23 Apr 2021 12:13:27 -0400 Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E9FEC061574 for ; Fri, 23 Apr 2021 09:12:49 -0700 (PDT) Received: by mail-ot1-x330.google.com with SMTP id e89-20020a9d01e20000b0290294134181aeso19931223ote.5 for ; Fri, 23 Apr 2021 09:12:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=t2yrefWokbt33zTb8tmxj08fAqkU3+m9KUoV5do9LC0=; b=PJ/zA3NEHcqEnhs54KzGFdXCkq4oVc/gAhKk8CPtOzBSe3RpJxzCnR8t0i5EWQ2rUn cBvcR75IV7rT/nCF4fzK4L8JBnVnV4fvzgBFlVnTefFtn/sUFAydBkgugBPl4u093wYZ UDBgcLOOuPdIfospceeYriu21HsVIX0XCEve5L1FragZ4PenxTOH+fi3cwYSG5rMeTin LtV8ITJCs8Q93hancAReZ5D8emnlNbC2HuKZKWPu6z95xsaBrZUQkp97rZArr0f5ra/j sXNPosDBmufG4qNw09oYtxTfSW/XWSxeGYTLVEb3D4jQD5sG/i5PvthnYHoL+Z7V9PIh FDCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=t2yrefWokbt33zTb8tmxj08fAqkU3+m9KUoV5do9LC0=; b=aVO50sKkmgrO48sNASJqfeE1q+M3GBzlGU9lb2forCz4Zx76gdSXy1R8ied3NVp2wt H4GYpLo+6CbslhrxoLyoXFGyk+XWXCk+oOKjZOfPYkT9AipNDPW7WuL9sIHQN9w4ETl7 l4FnaLmTteLCnJmA43BnA2bY6dBBJdMvwraATA5Ce/SwKmpOXmiUUf6typ3R1OHWCo0N yMXmq2Oht+KJ6MmkCnAI3pkvSOT9BU4qWOW6c3efKcvy+U8fzNkOfiO4gaVGlI4xD1ZS yzlS3tyx+Bqc9C7N23hf9wkTOwtNakNPNs3g9Jt/e6vjxXMnPuo6pmksU8yE8NiCr9Ey NtFA== X-Gm-Message-State: AOAM530C+EYvEw4cY8BQqQcr7uGmZXbzmnLs8Sme2uYU5Z71FsrByRgY AOB+FRc7b9sNq3v1bdIRYR0UuA== X-Google-Smtp-Source: ABdhPJz1tp/EQchiVjH4auFBqgFjc0Uz3XgKzC1NFD0VSi1F0QaLnrO+79sKOL4PwuCs206USDCV7A== X-Received: by 2002:a9d:5a1a:: with SMTP id v26mr4123172oth.50.1619194368866; Fri, 23 Apr 2021 09:12:48 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id x24sm1465060otk.16.2021.04.23.09.12.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Apr 2021 09:12:48 -0700 (PDT) Date: Fri, 23 Apr 2021 11:12:46 -0500 From: Bjorn Andersson To: Douglas Anderson Cc: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , Wolfram Sang , Stephen Boyd , robdclark@chromium.org, Maarten Lankhorst , Stanislav Lisovskiy , Steev Klimaszewski , linux-arm-msm@vger.kernel.org, Linus W , Daniel Vetter , David Airlie , Thierry Reding , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 24/27] drm/panel: panel-simple: Cache the EDID as long as we retain power Message-ID: References: <20210416223950.3586967-1-dianders@chromium.org> <20210416153909.v4.24.If050957eaa85cf45b10bcf61e6f7fa61c9750ebf@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210416153909.v4.24.If050957eaa85cf45b10bcf61e6f7fa61c9750ebf@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri 16 Apr 17:39 CDT 2021, Douglas Anderson wrote: > It doesn't make sense to go out to the bus and read the EDID over and > over again. Let's cache it and throw away the cache when we turn power > off from the panel. Autosuspend means that even if there are several > calls to read the EDID before we officially turn the power on then we > should get good use out of this cache. > > Signed-off-by: Douglas Anderson > --- > > (no changes since v1) > > drivers/gpu/drm/panel/panel-simple.c | 17 ++++++++++------- > 1 file changed, 10 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 40382c1be692..5a2953c4ca44 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -189,6 +189,8 @@ struct panel_simple { > struct gpio_desc *enable_gpio; > struct gpio_desc *hpd_gpio; > > + struct edid *edid; > + > struct drm_display_mode override_mode; > > enum drm_panel_orientation orientation; > @@ -345,6 +347,9 @@ static int panel_simple_suspend(struct device *dev) > regulator_disable(p->supply); > p->unprepared_time = ktime_get(); > > + kfree(p->edid); > + p->edid = NULL; Reviewed-by: Bjorn Andersson But separate of this, shouldn't the driver have a pm_runtime_disable() in the remove path to synchronize the autosleep? Or is that not how that works? Regards, Bjorn > + > return 0; > } > > @@ -510,15 +515,13 @@ static int panel_simple_get_modes(struct drm_panel *panel, > > /* probe EDID if a DDC bus is available */ > if (p->ddc) { > - struct edid *edid; > - > pm_runtime_get_sync(panel->dev); > > - edid = drm_get_edid(connector, p->ddc); > - if (edid) { > - num += drm_add_edid_modes(connector, edid); > - kfree(edid); > - } > + if (!p->edid) > + p->edid = drm_get_edid(connector, p->ddc); > + > + if (p->edid) > + num += drm_add_edid_modes(connector, p->edid); > > pm_runtime_mark_last_busy(panel->dev); > pm_runtime_put_autosuspend(panel->dev); > -- > 2.31.1.368.gbe11c130af-goog >