From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: khsieh@codeaurora.org, swboyd@chromium.org
Cc: robdclark@gmail.com, sean@poorly.run, vkoul@kernel.org,
agross@kernel.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, abhinavk@codeaurora.org,
aravindh@codeaurora.org, freedreno@lists.freedesktop.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64/dts/qcom/sc7180: Add Display Port dt node
Date: Mon, 7 Jun 2021 18:31:47 -0500 [thread overview]
Message-ID: <YL6sY/1E5wLzMiP/@yoga> (raw)
In-Reply-To: <ef1879fa7ecfefaf0c70c7a4782240a9@codeaurora.org>
On Mon 07 Jun 12:48 CDT 2021, khsieh@codeaurora.org wrote:
> On 2021-06-05 22:07, Bjorn Andersson wrote:
> > On Thu 03 Jun 16:56 CDT 2021, khsieh@codeaurora.org wrote:
> >
> > > On 2021-06-03 09:53, Bjorn Andersson wrote:
> > > > On Thu 03 Jun 11:09 CDT 2021, Kuogee Hsieh wrote:
> > [..]
> > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> > [..]
> > > > > + power-domains = <&rpmhpd SC7180_CX>;
> > > >
> > > > Just curious, but isn't the DP block in the MDSS_GDCS? Or do we need to
> > > > mention CX here in order for the opp framework to apply required-opps
> > > > of CX?
> > >
> > > yes,
> >
> > If you want me, or other maintainers, to spend any time reviewing or
> > applying your patches going forward then you need to actually bother
> > replying properly to the questions asked.
> >
> > Thanks,
> > Bjorn
>
> Sorry about the confusion. What I meant is that even though DP controller is
> in the MDSS_GDSC
> power domain, DP PHY/PLL sources out of CX. The DP link clocks have a direct
> impact
> on the CX voltage corners. Therefore, we need to mention the CX power domain
> here. And, since
> we can associate only one OPP table with one device, we picked the DP link
> clock over other
> clocks.
Thank you, that's a much more useful answer.
Naturally I would think it would make more sense for the PHY/PLL driver
to ensure that CX is appropriately voted for then, but I think that
would result in it being the clock driver performing such vote and I'm
unsure how the opp table for that would look.
@Stephen, what do you say?
Regards,
Bjorn
next prev parent reply other threads:[~2021-06-07 23:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 16:09 [PATCH v2] arm64/dts/qcom/sc7180: Add Display Port dt node Kuogee Hsieh
2021-06-03 16:53 ` Bjorn Andersson
2021-06-03 21:28 ` khsieh
2021-06-03 21:35 ` Stephen Boyd
2021-06-03 21:56 ` khsieh
2021-06-06 5:07 ` Bjorn Andersson
2021-06-07 17:48 ` khsieh
2021-06-07 23:31 ` Bjorn Andersson [this message]
2021-06-08 22:15 ` Stephen Boyd
2021-06-08 22:26 ` Bjorn Andersson
2021-06-08 22:29 ` Stephen Boyd
2021-06-08 22:34 ` Bjorn Andersson
2021-06-08 22:44 ` Stephen Boyd
2021-06-08 23:10 ` Bjorn Andersson
2021-06-10 16:54 ` khsieh
2021-06-18 20:49 ` Stephen Boyd
2021-06-18 21:41 ` Bjorn Andersson
2021-06-22 20:23 ` Stephen Boyd
2021-06-23 2:52 ` Bjorn Andersson
2021-06-25 15:55 ` khsieh
2021-06-25 16:04 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YL6sY/1E5wLzMiP/@yoga \
--to=bjorn.andersson@linaro.org \
--cc=abhinavk@codeaurora.org \
--cc=agross@kernel.org \
--cc=aravindh@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=freedreno@lists.freedesktop.org \
--cc=khsieh@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).