From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Siddharth Gupta <sidgup@codeaurora.org>
Cc: ohad@wizery.com, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2 0/4] remoteproc: core: Fixes for rproc cdev and add
Date: Mon, 14 Jun 2021 15:59:14 -0500 [thread overview]
Message-ID: <YMfDItBIwGtyqAEd@builder.lan> (raw)
In-Reply-To: <1623703244-26814-1-git-send-email-sidgup@codeaurora.org>
On Mon 14 Jun 15:40 CDT 2021, Siddharth Gupta wrote:
> This patch series contains stability fixes and error handling for remoteproc.
>
Thanks for respinning this Sid, I think patch 3 looks good now as well,
but it seems you accidentally got an additional file in the same patch.
Can you please fix that up and resend the patches?
Regards,
Bjorn
> The changes included in this series do the following:
> Patch 1: Fixes the creation of the rproc character device.
> Patch 2: Validates rproc as the first step of rproc_add().
> Patch 3: Fixes the rproc cdev remove and the order of dev_del() and cdev_del().
> Patch 4: Adds error handling in rproc_add().
>
> v1 -> v2:
> - Added extra patch which addresses Bjorn's comments on patch 3
> from v1.
> - Fixed commit text for patch 2 (s/calling making/making).
>
> Siddharth Gupta (4):
> remoteproc: core: Move cdev add before device add
> remoteproc: core: Move validate before device add
> remoteproc: core: Fix cdev remove and rproc del
> remoteproc: core: Cleanup device in case of failure
>
> 0000-cover-letter.patch.backup | 26 ++++++++++++++++++++++++++
> drivers/remoteproc/remoteproc_cdev.c | 2 +-
> drivers/remoteproc/remoteproc_core.c | 27 ++++++++++++++++++---------
> 3 files changed, 45 insertions(+), 10 deletions(-)
> create mode 100644 0000-cover-letter.patch.backup
>
> --
> Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
prev parent reply other threads:[~2021-06-14 20:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 20:40 [PATCH v2 0/4] remoteproc: core: Fixes for rproc cdev and add Siddharth Gupta
2021-06-14 20:40 ` [PATCH v2 1/4] remoteproc: core: Move cdev add before device add Siddharth Gupta
2021-06-14 20:40 ` [PATCH v2 2/4] remoteproc: core: Move validate " Siddharth Gupta
2021-06-14 20:40 ` [PATCH v2 3/4] remoteproc: core: Fix cdev remove and rproc del Siddharth Gupta
2021-06-14 20:40 ` [PATCH v2 4/4] remoteproc: core: Cleanup device in case of failure Siddharth Gupta
2021-06-14 20:59 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMfDItBIwGtyqAEd@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=psodagud@codeaurora.org \
--cc=sidgup@codeaurora.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).