linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, lgirdwood@gmail.com,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v3 1/4] dt-bindings: pinctrl: qcom,pmic-gpio: Arrange compatibles alphabetically
Date: Fri, 18 Jun 2021 12:59:53 -0500	[thread overview]
Message-ID: <YMzfGctdFGytohFQ@builder.lan> (raw)
In-Reply-To: <20210617053432.350486-2-bhupesh.sharma@linaro.org>

On Thu 17 Jun 00:34 CDT 2021, Bhupesh Sharma wrote:

> Arrange the compatibles inside qcom-pmic gpio device tree
> bindings alphabetically.
> 
> While at it, also make some minor cosmetic changes to allow
> future compatible addition to the bindings simpler.
> 

I think we're rather close to getting the YAML binding sorted out, but
this patch does look good and doesn't hurt.

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
>  .../bindings/pinctrl/qcom,pmic-gpio.txt       | 58 +++++++++----------
>  1 file changed, 29 insertions(+), 29 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> index f6a9760558a6..10f049e21264 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> @@ -7,10 +7,20 @@ PMIC's from Qualcomm.
>  	Usage: required
>  	Value type: <string>
>  	Definition: must be one of:
> +		    "qcom,pm660-gpio"
> +		    "qcom,pm660l-gpio"
> +		    "qcom,pm6150-gpio"
> +		    "qcom,pm6150l-gpio"
>  		    "qcom,pm8005-gpio"
> +		    "qcom,pm8008-gpio"
>  		    "qcom,pm8018-gpio"
>  		    "qcom,pm8038-gpio"
>  		    "qcom,pm8058-gpio"
> +		    "qcom,pm8150-gpio"
> +		    "qcom,pm8150b-gpio"
> +		    "qcom,pm8350-gpio"
> +		    "qcom,pm8350b-gpio"
> +		    "qcom,pm8350c-gpio"
>  		    "qcom,pm8916-gpio"
>  		    "qcom,pm8917-gpio"
>  		    "qcom,pm8921-gpio"
> @@ -22,20 +32,10 @@ PMIC's from Qualcomm.
>  		    "qcom,pmi8950-gpio"
>  		    "qcom,pmi8994-gpio"
>  		    "qcom,pmi8998-gpio"
> -		    "qcom,pms405-gpio"
> -		    "qcom,pm660-gpio"
> -		    "qcom,pm660l-gpio"
> -		    "qcom,pm8150-gpio"
> -		    "qcom,pm8150b-gpio"
> -		    "qcom,pm8350-gpio"
> -		    "qcom,pm8350b-gpio"
> -		    "qcom,pm8350c-gpio"
>  		    "qcom,pmk8350-gpio"
>  		    "qcom,pmr735a-gpio"
>  		    "qcom,pmr735b-gpio"
> -		    "qcom,pm6150-gpio"
> -		    "qcom,pm6150l-gpio"
> -		    "qcom,pm8008-gpio"
> +		    "qcom,pms405-gpio"
>  		    "qcom,pmx55-gpio"
>  
>  		    And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
> @@ -97,34 +97,34 @@ to specify in a pin configuration subnode:
>  	Value type: <string-array>
>  	Definition: List of gpio pins affected by the properties specified in
>  		    this subnode.  Valid pins are:
> -		    gpio1-gpio4 for pm8005
> -		    gpio1-gpio6 for pm8018
> +		    gpio1-gpio10 for pm6150
> +		    gpio1-gpio12 for pm6150l
> +		    gpio1-gpio4  for pm8005
> +		    gpio1-gpio2  for pm8008
> +		    gpio1-gpio6  for pm8018
>  		    gpio1-gpio12 for pm8038
>  		    gpio1-gpio40 for pm8058
> -		    gpio1-gpio4 for pm8916
> +		    gpio1-gpio10 for pm8150 (holes on gpio2, gpio5, gpio7
> +					     and gpio8)
> +		    gpio1-gpio12 for pm8150b (holes on gpio3, gpio4, gpio7)
> +		    gpio1-gpio12 for pm8150l (hole on gpio7)
> +		    gpio1-gpio10 for pm8350
> +		    gpio1-gpio8  for pm8350b
> +		    gpio1-gpio9  for pm8350c
> +		    gpio1-gpio4  for pm8916
>  		    gpio1-gpio38 for pm8917
>  		    gpio1-gpio44 for pm8921
>  		    gpio1-gpio36 for pm8941
> -		    gpio1-gpio8 for pm8950 (hole on gpio3)
> +		    gpio1-gpio8  for pm8950 (hole on gpio3)
>  		    gpio1-gpio22 for pm8994
>  		    gpio1-gpio26 for pm8998
>  		    gpio1-gpio22 for pma8084
> -		    gpio1-gpio2 for pmi8950
> +		    gpio1-gpio2  for pmi8950
>  		    gpio1-gpio10 for pmi8994
> +		    gpio1-gpio4  for pmk8350
> +		    gpio1-gpio4  for pmr735a
> +		    gpio1-gpio4  for pmr735b
>  		    gpio1-gpio12 for pms405 (holes on gpio1, gpio9 and gpio10)
> -		    gpio1-gpio10 for pm8150 (holes on gpio2, gpio5, gpio7
> -					     and gpio8)
> -		    gpio1-gpio12 for pm8150b (holes on gpio3, gpio4, gpio7)
> -		    gpio1-gpio12 for pm8150l (hole on gpio7)
> -		    gpio1-gpio10 for pm8350
> -		    gpio1-gpio8 for pm8350b
> -		    gpio1-gpio9 for pm8350c
> -		    gpio1-gpio4 for pmk8350
> -		    gpio1-gpio4 for pmr735a
> -		    gpio1-gpio4 for pmr735b
> -		    gpio1-gpio10 for pm6150
> -		    gpio1-gpio12 for pm6150l
> -		    gpio1-gpio2 for pm8008
>  		    gpio1-gpio11 for pmx55 (holes on gpio3, gpio7, gpio10
>  					    and gpio11)
>  
> -- 
> 2.31.1
> 

  reply	other threads:[~2021-06-18 17:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17  5:34 [PATCH v3 0/4] pinctrl: qcom/pinctrl-spmi-gpio: Add support for pmic-gpio on SA8155p-adp Bhupesh Sharma
2021-06-17  5:34 ` [PATCH v3 1/4] dt-bindings: pinctrl: qcom,pmic-gpio: Arrange compatibles alphabetically Bhupesh Sharma
2021-06-18 17:59   ` Bjorn Andersson [this message]
2021-06-24 21:24   ` Rob Herring
2021-06-25 23:51   ` Linus Walleij
2021-06-26 18:29     ` Bhupesh Sharma
2021-06-29 12:36       ` Bhupesh Sharma
2021-06-17  5:34 ` [PATCH v3 2/4] dt-bindings: pinctrl: qcom,pmic-gpio: Add compatible for SA8155p-adp Bhupesh Sharma
2021-06-18 18:00   ` Bjorn Andersson
2021-06-24 21:24   ` Rob Herring
2021-06-17  5:34 ` [PATCH v3 3/4] pinctrl: qcom/pinctrl-spmi-gpio: Arrange compatibles alphabetically Bhupesh Sharma
2021-06-18 18:02   ` Bjorn Andersson
2021-06-17  5:34 ` [PATCH v3 4/4] pinctrl: qcom/pinctrl-spmi-gpio: Add compatible for pmic-gpio on SA8155p-adp Bhupesh Sharma
2021-06-18 18:02   ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMzfGctdFGytohFQ@builder.lan \
    --to=bjorn.andersson@linaro.org \
    --cc=bhupesh.linux@gmail.com \
    --cc=bhupesh.sharma@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).