From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Marijn Suijten <marijn.suijten@somainline.org>
Cc: phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Martin Botka <martin.botka@somainline.org>,
Jami Kettunen <jami.kettunen@somainline.org>,
Pavel Dubrova <pashadubrova@gmail.com>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Brian Masney <masneyb@onstation.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: dts: qcom-msm8974: Add xo_board reference clock to DSI0 PHY
Date: Mon, 30 Aug 2021 16:28:15 -0500 [thread overview]
Message-ID: <YS1NbxhPrAPIQwk3@yoga> (raw)
In-Reply-To: <20210830175739.143401-1-marijn.suijten@somainline.org>
On Mon 30 Aug 12:57 CDT 2021, Marijn Suijten wrote:
> According to YAML validation, and for a future patchset putting this
> xo_board reference clock to use as VCO reference parent, add the missing
> clock to dsi_phy0.
>
And just to confirm on MSM8974 "ref" is supposed to be 19.2Mhz?
Regards,
Bjorn
> Fixes: 5a9fc531f6ec ("ARM: dts: msm8974: add display support")
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
> ---
> arch/arm/boot/dts/qcom-msm8974.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
> index db4c06bf7888..96722172b064 100644
> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> @@ -1580,8 +1580,8 @@ dsi_phy0: dsi-phy@fd922a00 {
> #phy-cells = <0>;
> qcom,dsi-phy-index = <0>;
>
> - clocks = <&mmcc MDSS_AHB_CLK>;
> - clock-names = "iface";
> + clocks = <&mmcc MDSS_AHB_CLK>, <&xo_board>;
> + clock-names = "iface", "ref";
> };
> };
>
> --
> 2.33.0
>
next prev parent reply other threads:[~2021-08-30 21:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 17:57 [PATCH] arm: dts: qcom-msm8974: Add xo_board reference clock to DSI0 PHY Marijn Suijten
2021-08-30 21:28 ` Bjorn Andersson [this message]
2021-08-30 22:15 ` Marijn Suijten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YS1NbxhPrAPIQwk3@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=devicetree@vger.kernel.org \
--cc=jami.kettunen@somainline.org \
--cc=konrad.dybcio@somainline.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=masneyb@onstation.org \
--cc=pashadubrova@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).