From: Melody Olvera <quic_molvera@quicinc.com>
To: Vinod Koul <vkoul@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <dmaengine@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] dmaengine: qcom: gpi: Add compatible for QDU1000 and QRU1000
Date: Wed, 19 Oct 2022 10:08:16 -0700 [thread overview]
Message-ID: <a4db0335-33d8-76cd-6f89-b8bde603aedf@quicinc.com> (raw)
In-Reply-To: <Y0/75E7MqCpQml+I@matsya>
On 10/19/2022 6:30 AM, Vinod Koul wrote:
> On 15-10-22, 09:42, Krzysztof Kozlowski wrote:
>> On 14/10/2022 18:11, Melody Olvera wrote:
>>> Add compatible fields for the Qualcomm QDU1000 and QRU1000 SoCs.
>>>
>>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>>> ---
>>> drivers/dma/qcom/gpi.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
>>> index cc938a31dc2d..02438735e92b 100644
>>> --- a/drivers/dma/qcom/gpi.c
>>> +++ b/drivers/dma/qcom/gpi.c
>>> @@ -2286,6 +2286,8 @@ static int gpi_probe(struct platform_device *pdev)
>>> }
>>>
>>> static const struct of_device_id gpi_of_match[] = {
>>> + { .compatible = "qcom,qdu1000-gpi-dma", .data = (void *)0x10000 },
>>> + { .compatible = "qcom,qru1000-gpi-dma", .data = (void *)0x10000 },
>> The feedback was: drop entire patch.
>>
>> There is really no need for this pattern to keep growing.
> Right, I have picked the patches so you dont need to add yours to driver
> file, please check dmaengine/next
>
Yes, I think I understand now; I'll just use existing compatibles and drop this PS.
Thanks,
Melody
next prev parent reply other threads:[~2022-10-19 17:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 22:11 [PATCH v2 0/2] Add dma gpi support for QDU1000/QRU1000 SoCs Melody Olvera
2022-10-14 22:11 ` [PATCH v2 1/2] dt-bindings: dmaengine: qcom: gpi: Add compatible for QDU1000 and QRU1000 Melody Olvera
2022-10-14 22:11 ` [PATCH v2 2/2] " Melody Olvera
2022-10-15 13:42 ` Krzysztof Kozlowski
2022-10-19 13:30 ` Vinod Koul
2022-10-19 17:08 ` Melody Olvera [this message]
2022-10-14 23:56 ` [PATCH v2 0/2] Add dma gpi support for QDU1000/QRU1000 SoCs Melody Olvera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4db0335-33d8-76cd-6f89-b8bde603aedf@quicinc.com \
--to=quic_molvera@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).