From: Sibi Sankar <sibis@codeaurora.org>
To: Rob Herring <robh@kernel.org>
Cc: bjorn.andersson@linaro.org, mathieu.poirier@linaro.org,
swboyd@chromium.org, ulf.hansson@linaro.org, rjw@rjwysocki.net,
agross@kernel.org, ohad@wizery.com,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dianders@chromium.org, rishabhb@codeaurora.org,
sidgup@codeaurora.org
Subject: Re: [PATCH v2 02/13] dt-bindings: remoteproc: qcom: pas: Add QMP bindings
Date: Tue, 22 Jun 2021 12:53:17 +0530 [thread overview]
Message-ID: <cbf3f5b190f9ea15a2246dc836513b46@codeaurora.org> (raw)
In-Reply-To: <20210618202512.GA2811174@robh.at.kernel.org>
Hey Rob,
Thanks for the review.
On 2021-06-19 01:55, Rob Herring wrote:
> On Mon, Jun 07, 2021 at 09:09:21PM +0530, Sibi Sankar wrote:
>> Add Qualcomm Mailbox Protocol (QMP) binding to replace the power
>> domains
>> exposed by the AOSS QMP node.
>>
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>>
>> v2:
>> * Drop R-b from Rob/Stephen due to yaml conversion.
>>
>> .../devicetree/bindings/remoteproc/qcom,adsp.yaml | 40
>> +++++++++++++++-------
>> 1 file changed, 27 insertions(+), 13 deletions(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
>> b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
>> index 9ea05e608bc1..b6396bc07388 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
>> @@ -89,6 +89,10 @@ properties:
>> maxItems: 1
>> description: Reference to the reserved-memory for the Hexagon
>> core
>>
>> + qcom,qmp:
>
> Is there more than one QMP? If not just search for the QMP node and you
> can avoid the ABI issue at least partially.
yeah there is just one qmp node
used by all remote processors and
we just search for the qmp node.
>
>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>
> There's more than 1 cell? What's in them?
Just a single cell i.e. handle to the
qmp node. I'll fix this in the re-spin.
>
>> + description: Reference to the AOSS side-channel message RAM.
>> +
>> qcom,smem-states:
>> $ref: /schemas/types.yaml#/definitions/phandle-array
>> description: States used by the AP to signal the Hexagon core
>> @@ -359,13 +363,11 @@ allOf:
>> properties:
>> power-domains:
>> items:
>> - - description: Load State power domain
>> - description: CX power domain
>> - description: MX power domain
>> - description: MSS power domain
>> power-domain-names:
>> items:
>> - - const: load_state
>> - const: cx
>> - const: mx
>> - const: mss
>> @@ -381,12 +383,7 @@ allOf:
>> properties:
>> power-domains:
>> items:
>> - - description: Load State power domain
>> - description: CX power domain
>> - power-domain-names:
>> - items:
>> - - const: load_state
>> - - const: cx
>>
>> - if:
>> properties:
>> @@ -399,12 +396,10 @@ allOf:
>> properties:
>> power-domains:
>> items:
>> - - description: Load State power domain
>> - description: CX power domain
>> - description: MSS power domain
>> power-domain-names:
>> items:
>> - - const: load_state
>> - const: cx
>> - const: mss
>>
>> @@ -439,12 +434,10 @@ allOf:
>> properties:
>> power-domains:
>> items:
>> - - description: Load State power domain
>> - description: LCX power domain
>> - description: LMX power domain
>> power-domain-names:
>> items:
>> - - const: load_state
>> - const: lcx
>> - const: lmx
>>
>> @@ -458,12 +451,10 @@ allOf:
>> properties:
>> power-domains:
>> items:
>> - - description: Load State power domain
>> - description: CX power domain
>> - description: MXC power domain
>> power-domain-names:
>> items:
>> - - const: load_state
>> - const: cx
>> - const: mxc
>>
>> @@ -499,6 +490,29 @@ allOf:
>> - const: mss_restart
>> - const: pdc_reset
>>
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - qcom,sc7180-mpss-pas
>> + - qcom,sm8150-adsp-pas
>> + - qcom,sm8150-cdsp-pas
>> + - qcom,sm8150-mpss-pas
>> + - qcom,sm8150-slpi-pas
>> + - qcom,sm8250-adsp-pas
>> + - qcom,sm8250-cdsp-pas
>> + - qcom,sm8250-slpi-pas
>> + - qcom,sm8350-adsp-pas
>> + - qcom,sm8350-cdsp-pas
>> + - qcom,sm8350-mpss-pas
>> + - qcom,sm8350-slpi-pas
>> + then:
>> + properties:
>> + qcom,qmp:
>> + items:
>> + - description: Reference to the AOSS side-channel message
>> RAM.
>> +
>> examples:
>> - |
>> #include <dt-bindings/clock/qcom,rpmcc.h>
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project
>>
>>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2021-06-22 7:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 15:39 [PATCH v2 00/13] Use qmp_send to update co-processor load state Sibi Sankar
2021-06-07 15:39 ` [PATCH v2 01/13] dt-bindings: soc: qcom: aoss: Drop power-domain bindings Sibi Sankar
2021-06-18 20:19 ` Rob Herring
2021-06-07 15:39 ` [PATCH v2 02/13] dt-bindings: remoteproc: qcom: pas: Add QMP bindings Sibi Sankar
2021-06-18 20:25 ` Rob Herring
2021-06-22 7:23 ` Sibi Sankar [this message]
2021-06-07 15:39 ` [PATCH v2 03/13] dt-bindings: remoteproc: qcom: " Sibi Sankar
2021-06-07 15:39 ` [PATCH v2 04/13] remoteproc: qcom: q6v5: Use qmp_send to update co-processor load state Sibi Sankar
2021-06-07 15:39 ` [PATCH v2 05/13] arm64: dts: qcom: sc7180: Use QMP binding to control " Sibi Sankar
2021-06-07 15:39 ` [PATCH v2 06/13] arm64: dts: qcom: sc7280: " Sibi Sankar
2021-06-07 15:39 ` [PATCH v2 07/13] arm64: dts: qcom: sdm845: " Sibi Sankar
2021-06-07 15:39 ` [PATCH v2 08/13] arm64: dts: qcom: sm8150: " Sibi Sankar
2021-06-07 15:39 ` [PATCH v2 09/13] arm64: dts: qcom: sm8250: " Sibi Sankar
2021-06-07 15:39 ` [PATCH v2 10/13] arm64: dts: qcom: sm8350: " Sibi Sankar
2021-06-07 15:39 ` [PATCH v2 11/13] soc: qcom: aoss: Drop power domain support Sibi Sankar
2021-06-07 15:39 ` [PATCH v2 12/13] dt-bindings: msm/dp: Remove aoss-qmp header Sibi Sankar
2021-06-18 20:25 ` Rob Herring
2021-06-07 15:39 ` [PATCH v2 13/13] dt-bindings: soc: qcom: aoss: Delete unused power-domain definitions Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbf3f5b190f9ea15a2246dc836513b46@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
--cc=rishabhb@codeaurora.org \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=sidgup@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).