From: skakit@codeaurora.org
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
mka@chromium.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
kgunda@codeaurora.org
Subject: Re: [RESEND PATCH V4 4/8] arm64: dts: qcom: pm8350c: Add temp-alarm support
Date: Thu, 20 May 2021 11:55:01 +0530 [thread overview]
Message-ID: <dab01d12ae52026a1b05e85604bff972@codeaurora.org> (raw)
In-Reply-To: <YKOpc+mi9fxVRMbI@vkoul-mobl.Dlink>
On 2021-05-18 17:18, Vinod Koul wrote:
> On 18-05-21, 11:50, satya priya wrote:
>> Add temp-alarm node for PM8350C pmic and also modify gpio
>> node to add gpio ranges and "qcom,spmi-gpio" compatible.
>
> These should be two patches explaining why things are done like that
>
Okay, will split them.
>>
>> Signed-off-by: satya priya <skakit@codeaurora.org>
>> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
>> ---
>> Changes in RESEND V4:
>> - No Changes.
>>
>> arch/arm64/boot/dts/qcom/pm8350c.dtsi | 32
>> +++++++++++++++++++++++++++++++-
>> 1 file changed, 31 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
>> b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
>> index 2b9b75e..e1b75ae 100644
>> --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
>> @@ -13,13 +13,43 @@
>> #address-cells = <1>;
>> #size-cells = <0>;
>>
>> + pm8350c_temp_alarm: temp-alarm@a00 {
>> + compatible = "qcom,spmi-temp-alarm";
>> + reg = <0xa00>;
>> + interrupts = <0x2 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
>> + #thermal-sensor-cells = <0>;
>> + };
>> +
>> pm8350c_gpios: gpio@8800 {
>> - compatible = "qcom,pm8350c-gpio";
>> + compatible = "qcom,pm8350c-gpio", "qcom,spmi-gpio";
>
> why is this changed?
As per the Documentation[1], either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
must be added based on whether the device is on an spmi bus or an ssbi
bus respectively.
[1]
https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/pinctrl/qcom%2Cpmic-gpio.txt#L41
>
>> reg = <0x8800>;
>> gpio-controller;
>> + gpio-ranges = <&pm8350c_gpios 0 0 9>;
>> #gpio-cells = <2>;
>> interrupt-controller;
>> #interrupt-cells = <2>;
>> };
>> };
>> };
>> +
>> +&thermal_zones {
>> + pm8350c_thermal: pm8350c-thermal {
>> + polling-delay-passive = <100>;
>> + polling-delay = <0>;
>> + thermal-sensors = <&pm8350c_temp_alarm>;
>> +
>> + trips {
>> + pm8350c_trip0: trip0 {
>> + temperature = <95000>;
>> + hysteresis = <0>;
>> + type = "passive";
>> + };
>> +
>> + pm8350c_crit: pm8350c-crit {
>> + temperature = <115000>;
>> + hysteresis = <0>;
>> + type = "critical";
>> + };
>> + };
>> + };
>> +};
>> --
>> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
>> member
>> of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2021-05-20 6:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 6:20 [RESEND PATCH V4 0/8] Add PMIC DT files for sc7280 satya priya
2021-05-18 6:20 ` [RESEND PATCH V4 1/8] arm64: dts: qcom: sm8350: Add label for thermal-zones node satya priya
2021-05-18 11:43 ` Vinod Koul
2021-05-20 6:24 ` skakit
2021-05-18 6:20 ` [RESEND PATCH V4 2/8] arm64: dts: qcom: sc7280: Add " satya priya
2021-05-18 11:44 ` Vinod Koul
2021-05-18 16:27 ` Matthias Kaehlcke
2021-05-18 21:16 ` Dmitry Baryshkov
2021-05-20 6:25 ` skakit
2021-05-18 6:20 ` [RESEND PATCH V4 3/8] arm64: dts: qcom: pm7325: Add pm7325 base dts file satya priya
2021-05-18 11:46 ` Vinod Koul
2021-05-18 16:42 ` Matthias Kaehlcke
2021-05-20 6:32 ` skakit
2021-05-20 7:20 ` Vinod Koul
2021-05-21 12:22 ` skakit
2021-05-18 6:20 ` [RESEND PATCH V4 4/8] arm64: dts: qcom: pm8350c: Add temp-alarm support satya priya
2021-05-18 11:48 ` Vinod Koul
2021-05-20 6:25 ` skakit [this message]
2021-05-18 6:20 ` [RESEND PATCH V4 5/8] arm64: dts: qcom: pmr735a: " satya priya
2021-05-18 6:20 ` [RESEND PATCH V4 6/8] arm64: dts: qcom: pmk8350: Add peripherals for pmk8350 satya priya
2021-05-18 6:20 ` [RESEND PATCH V4 7/8] arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280-idp satya priya
2021-05-18 6:20 ` [RESEND PATCH V4 8/8] arm64: dts: qcom: sc7280: Add ADC channel nodes for PMIC temperatures to sc7280-idp satya priya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dab01d12ae52026a1b05e85604bff972@codeaurora.org \
--to=skakit@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kgunda@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).