linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Akash Asthana <akashast@codeaurora.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: robh+dt@kernel.org, agross@kernel.org, mark.rutland@arm.com,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, mgautam@codeaurora.org,
	rojay@codeaurora.org, skakit@codeaurora.org, swboyd@chromium.org
Subject: Re: [PATCH V4 3/3] dt-bindings: geni-se: Add binding for UART pin swap
Date: Wed, 19 Feb 2020 18:51:35 +0530	[thread overview]
Message-ID: <ec5de895-3e86-811e-7ffc-fb98e115f850@codeaurora.org> (raw)
In-Reply-To: <20200218190731.GC15781@google.com>

Hi Matthias,

On 2/19/2020 12:37 AM, Matthias Kaehlcke wrote:
> Hi Akash,
>
> I didn't see a patch that implements the binding, did you post it?

We haven't posted any update on patch@ 
https://patchwork.kernel.org/cover/11313817/

[tty: serial: qcom_geni_serial: Configure UART_IO_MACRO_CTRL register]. 
We will spin it ASAP.

>
>
> On Mon, Feb 17, 2020 at 03:06:52PM +0530, Akash Asthana wrote:
>> Add documentation to support RX/TX/CTS/RTS pin swap in HW.
>>
>> Signed-off-by: Akash Asthana <akashast@codeaurora.org>
>> ---
>>   Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
>> index 11530df..7e4b9af 100644
>> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
>> @@ -165,6 +165,15 @@ patternProperties:
>>             - description: UART core irq
>>             - description: Wakeup irq (RX GPIO)
>>   
>> +      rx-tx-swap:
>> +        description: RX and TX pins are swap.
> s/swap/swapped/
Ok
>
>> +
>> +      cts-rts-swap:
>> +        description: CTS and RTS pins are swap.
> s/swap/swapped/
Ok
>
>> +
>> +      rx-tx-cts-rts-swap:
>> +        description: RX-TX and CTS-RTS both pairs are swap.
> I don't think this option adds much value, if both pairs are swapped
> the above two properties can be set.

Yeah ok, It is possible to derive value for rx-tx-cts-rts if above 2 
properties are set.

>
>> +
>>       required:
>>         - compatible
>>         - interrupts
>> -- 
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project

Thanks for reviewing,


Regards,

Akash

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project

  reply	other threads:[~2020-02-19 13:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-17  9:36 [PATCH V4 0/3] Convert QUP bindings to YAML and add ICC, pin swap doc Akash Asthana
2020-02-17  9:36 ` [PATCH V4 1/3] dt-bindings: geni-se: Convert QUP geni-se bindings to YAML Akash Asthana
2020-02-18 21:19   ` Rob Herring
2020-02-25 18:20   ` Stephen Boyd
2020-02-17  9:36 ` [PATCH V4 2/3] dt-bindings: geni-se: Add interconnect binding for GENI QUP Akash Asthana
2020-02-18 21:19   ` Rob Herring
2020-02-25 18:21   ` Stephen Boyd
2020-02-17  9:36 ` [PATCH V4 3/3] dt-bindings: geni-se: Add binding for UART pin swap Akash Asthana
2020-02-18 19:07   ` Matthias Kaehlcke
2020-02-19 13:21     ` Akash Asthana [this message]
2020-03-10 21:57       ` Matthias Kaehlcke
2020-03-11 13:04         ` Akash Asthana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec5de895-3e86-811e-7ffc-fb98e115f850@codeaurora.org \
    --to=akashast@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mgautam@codeaurora.org \
    --cc=mka@chromium.org \
    --cc=robh+dt@kernel.org \
    --cc=rojay@codeaurora.org \
    --cc=skakit@codeaurora.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).