linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: linux-arm-msm@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH 15/15] arm64: dts: qcom: sm8450: add i2c13 and i2c14 device nodes
Date: Wed, 1 Dec 2021 16:30:37 +0100	[thread overview]
Message-ID: <ee38afe9-0e9e-cae1-c4c5-70db9f166a38@somainline.org> (raw)
In-Reply-To: <20211201072915.3969178-16-vkoul@kernel.org>


On 01.12.2021 08:29, Vinod Koul wrote:
> From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> Add device tree nodes for two i2c blocks: i2c13 and i2c14.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
>  arch/arm64/boot/dts/qcom/sm8450.dtsi | 64 ++++++++++++++++++++++++++++
>  1 file changed, 64 insertions(+)
>
[...]


>  		config_noc: interconnect@1500000 {
>  			compatible = "qcom,sm8450-config-noc";
>  			reg = <0 0x01500000 0 0x1c000>;
> @@ -687,6 +725,32 @@ tlmm: pinctrl@f100000 {
>  			gpio-ranges = <&tlmm 0 0 211>;
>  			wakeup-parent = <&pdc>;
>  
> +			qup_i2c13_default_state: qup-i2c13-default-state {
> +				mux {
> +					pins = "gpio48", "gpio49";
> +					function = "qup13";
> +				};
> +
> +				config {
> +					pins = "gpio48", "gpio49";
> +					drive-strength = <2>;
> +					bias-pull-up;
> +				};
> +			};
> +

This should be collapsed into:


qup_i2c13_default_state: qup-i2c13-default-state {

        pins = "..."

        function = "..."

        drive-strength = <2>

        bias-pull-up;

};


And the same goes for the rest of the pins.


[...]


Konrad


  reply	other threads:[~2021-12-01 15:30 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-01  7:29 [PATCH 00/15] arm64: dts: qcom: Add support for SM8450 SoC and QRD board Vinod Koul
2021-12-01  7:29 ` [PATCH 01/15] arm64: dts: qcom: Add base SM8450 DTSI Vinod Koul
2021-12-01 15:03   ` Konrad Dybcio
2021-12-06  5:39     ` Vinod Koul
2021-12-07 14:35       ` Bjorn Andersson
2021-12-07 14:53   ` Bjorn Andersson
2021-12-01  7:29 ` [PATCH 02/15] arm64: dts: qcom: Add base SM8450 QRD DTS Vinod Koul
2021-12-01 15:05   ` Konrad Dybcio
2021-12-01  7:29 ` [PATCH 03/15] arm64: dts: qcom: sm8450: Add tlmm nodes Vinod Koul
2021-12-07 14:37   ` Bjorn Andersson
2021-12-01  7:29 ` [PATCH 04/15] arm64: dts: qcom: sm8450-qrd: Add reserved gpio range for QRD Vinod Koul
2021-12-01 15:07   ` Konrad Dybcio
2021-12-06  5:53     ` Vinod Koul
2021-12-07 14:56       ` Bjorn Andersson
2021-12-01  7:29 ` [PATCH 05/15] arm64: dts: qcom: sm8450: Add reserved memory nodes Vinod Koul
2021-12-01 15:11   ` Konrad Dybcio
2021-12-06  5:42     ` Vinod Koul
2021-12-01  7:29 ` [PATCH 06/15] arm64: dts: qcom: sm8450: add smmu nodes Vinod Koul
2021-12-01 15:13   ` Konrad Dybcio
2021-12-01  7:29 ` [PATCH 07/15] arm64: dts: qcom: sm8450-qrd: Add rpmh regulator nodes Vinod Koul
2021-12-01 15:14   ` Konrad Dybcio
2021-12-01  7:29 ` [PATCH 08/15] arm64: dts: qcom: sm8450: add ufs nodes Vinod Koul
2021-12-01 15:16   ` Konrad Dybcio
2021-12-01  7:29 ` [PATCH 09/15] arm64: dts: qcom: sm8450-qrd: enable " Vinod Koul
2021-12-01 15:18   ` Konrad Dybcio
2021-12-06  5:58     ` Vinod Koul
2021-12-07 15:01       ` Bjorn Andersson
2021-12-01  7:29 ` [PATCH 10/15] arm64: dts: qcom: sm8450: add interconnect nodes Vinod Koul
2021-12-01 15:20   ` Konrad Dybcio
2021-12-06  6:12     ` Vinod Koul
2021-12-01  7:29 ` [PATCH 11/15] arm64: dts: qcom: sm8450: add spmi node Vinod Koul
2021-12-01 15:22   ` Konrad Dybcio
2021-12-01  7:29 ` [PATCH 12/15] arm64: dts: qcom: sm8450-qrd: include pmic files Vinod Koul
2021-12-01 15:23   ` Konrad Dybcio
2021-12-07 15:05     ` Bjorn Andersson
2021-12-07 15:51       ` Vinod Koul
2021-12-01  7:29 ` [PATCH 13/15] arm64: dts: qcom: sm8450: Add rpmhpd node Vinod Koul
2021-12-01 15:24   ` Konrad Dybcio
2021-12-01  7:29 ` [PATCH 14/15] arm64: dts: qcom: sm8450: add cpufreq support Vinod Koul
2021-12-01 15:28   ` Konrad Dybcio
2021-12-09  7:11     ` Vinod Koul
2021-12-01  7:29 ` [PATCH 15/15] arm64: dts: qcom: sm8450: add i2c13 and i2c14 device nodes Vinod Koul
2021-12-01 15:30   ` Konrad Dybcio [this message]
2021-12-09  7:13     ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee38afe9-0e9e-cae1-c4c5-70db9f166a38@somainline.org \
    --to=konrad.dybcio@somainline.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).