From: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
To: Thomas Zimmermann <tzimmermann@suse.de>, Sam Ravnborg <sam@ravnborg.org>
Cc: "Neil Armstrong" <narmstrong@baylibre.com>,
"Maxime Ripard" <maxime.ripard@bootlin.com>,
dri-devel@lists.freedesktop.org,
"Douglas Anderson" <dianders@chromium.org>,
linux-tegra@vger.kernel.org,
"Thierry Reding" <thierry.reding@gmail.com>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
kernel@collabora.com, linux-samsung-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org,
"Vincent Abriou" <vincent.abriou@st.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"David Airlie" <airlied@linux.ie>, "Chen-Yu Tsai" <wens@csie.org>,
"Kukjin Kim" <kgene@kernel.org>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Dave Airlie" <airlied@redhat.com>,
freedreno@lists.freedesktop.org,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Jonas Karlman" <jonas@kwiboo.se>,
linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
"Jyri Sarha" <jsarha@ti.com>,
"Alexios Zavras" <alexios.zavras@intel.com>,
"Mamta Shukla" <mamtashukla555@gmail.com>,
linux-mediatek@lists.infradead.org,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Sean Paul" <sean@poorly.run>,
linux-arm-kernel@lists.infradead.org,
"Jernej Skrabec" <jernej.skrabec@siol.net>,
amd-gfx@lists.freedesktop.org,
"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Seung-Woo Kim" <sw0312.kim@samsung.com>,
linux-kernel@vger.kernel.org,
"Todor Tomov" <todor.tomov@linaro.org>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Huang Rui" <ray.huang@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Christian König" <christian.koenig@amd.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [PATCH v4 14/23] drm/tilcdc: Provide ddc symlink in connector sysfs directory
Date: Wed, 24 Jul 2019 10:51:01 +0200 [thread overview]
Message-ID: <f051455a-3559-8f8e-cc76-1a6388b102b5@collabora.com> (raw)
In-Reply-To: <acfd895d-ab59-0190-e25c-1827bd8d214b@suse.de>
Hi Thomas,
W dniu 24.07.2019 o 10:01, Thomas Zimmermann pisze:
> Hi
>
>
> I think this echoes my concern about the implicit order of operation. It
> seems too easy to get this wrong. If you don't want to add an additional
> interface for setting the ddc field, why not add a dedicated initializer
> function that sets the ddc field? Something like this.
>
> int drm_connector_init_with_ddc(connector, funcs, ..., ddc)
> {
> ret = drm_connector_init(connector, funcs, ...);
> if (ret)
> return ret;
>
> if (!ddc)
> return 0;
>
> connector->ddc = ddc;
> /* set up sysfs */
>
> return 0;
> }
>
True. I will send a v5 soon.
Thanks,
Andrzej
next prev parent reply other threads:[~2019-07-24 8:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1562843413.git.andrzej.p@collabora.com>
[not found] ` <d32a6b1f0a3b79f1fbc8d0894080908526f6e61e.1562843413.git.andrzej.p@collabora.com>
2019-07-23 9:07 ` [PATCH v4 16/23] drm/mgag200: Provide ddc symlink in connector sysfs directory Sam Ravnborg
[not found] ` <d1d415022c598fb7acd033f0f322dd67250adaa9.1562843413.git.andrzej.p@collabora.com>
[not found] ` <20190723090532.GA787@ravnborg.org>
2019-07-23 12:44 ` [PATCH v4 14/23] drm/tilcdc: " Andrzej Pietrasiewicz
2019-07-23 15:19 ` Sam Ravnborg
2019-07-24 8:01 ` Thomas Zimmermann
2019-07-24 8:51 ` Andrzej Pietrasiewicz [this message]
2019-07-31 19:39 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f051455a-3559-8f8e-cc76-1a6388b102b5@collabora.com \
--to=andrzej.p@collabora.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=alexios.zavras@intel.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=jonathanh@nvidia.com \
--cc=jsarha@ti.com \
--cc=kernel@collabora.com \
--cc=kernel@pengutronix.de \
--cc=kgene@kernel.org \
--cc=kraxel@redhat.com \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mamtashukla555@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=maxime.ripard@bootlin.com \
--cc=narmstrong@baylibre.com \
--cc=ray.huang@amd.com \
--cc=rodrigo.vivi@intel.com \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
--cc=shawnguo@kernel.org \
--cc=sw0312.kim@samsung.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=todor.tomov@linaro.org \
--cc=tomi.valkeinen@ti.com \
--cc=tzimmermann@suse.de \
--cc=vincent.abriou@st.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).