From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF87BC433ED for ; Wed, 21 Apr 2021 19:39:10 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EEEF6142B for ; Wed, 21 Apr 2021 19:39:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EEEF6142B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-491-Bo8E1YNkNr-rBlcavypBYQ-1; Wed, 21 Apr 2021 15:39:05 -0400 X-MC-Unique: Bo8E1YNkNr-rBlcavypBYQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1A8BF343A4; Wed, 21 Apr 2021 19:39:02 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AEC515D9F2; Wed, 21 Apr 2021 19:39:01 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EFCC91806D1A; Wed, 21 Apr 2021 19:39:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13LHALI6016497 for ; Wed, 21 Apr 2021 13:10:22 -0400 Received: by smtp.corp.redhat.com (Postfix) id D0F1F103D21D; Wed, 21 Apr 2021 17:10:21 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CCE2A103D20C for ; Wed, 21 Apr 2021 17:10:19 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E72CB85A5A8 for ; Wed, 21 Apr 2021 17:10:18 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by relay.mimecast.com with ESMTP id us-mta-26-JHF5i796P3ud2j-2WPAmuQ-1; Wed, 21 Apr 2021 13:10:16 -0400 X-MC-Unique: JHF5i796P3ud2j-2WPAmuQ-1 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0047E11FB; Wed, 21 Apr 2021 10:10:16 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.3.41]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7BC1C3F694; Wed, 21 Apr 2021 10:10:14 -0700 (PDT) Date: Wed, 21 Apr 2021 18:10:05 +0100 From: Mark Rutland To: Will Deacon Subject: Re: [PATCH 1/3] arm64: ptrace: Add is_syscall_success to handle compat Message-ID: <20210421171005.GA46949@C02TD0UTHF1T.local> References: <20210416075533.7720-1-zhe.he@windriver.com> <20210416123322.GA23184@arm.com> <20210416133431.GA2303@C02TD0UTHF1T.local> <20210419121932.GA30004@willie-the-truck> MIME-Version: 1.0 In-Reply-To: <20210419121932.GA30004@willie-the-truck> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: linux-audit@redhat.com X-Mailman-Approved-At: Wed, 21 Apr 2021 15:38:59 -0400 Cc: He Zhe , Catalin Marinas , oleg@redhat.com, linux-kernel@vger.kernel.org, linux-audit@redhat.com, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Apr 19, 2021 at 01:19:33PM +0100, Will Deacon wrote: > On Fri, Apr 16, 2021 at 02:34:41PM +0100, Mark Rutland wrote: > > I think this is a problem we created for ourselves back in commit: > > > > 15956689a0e60aa0 ("arm64: compat: Ensure upper 32 bits of x0 are zero on syscall return) > > > > AFAICT, the perf regs samples are the only place this matters, since for > > ptrace the compat regs are implicitly truncated to compat_ulong_t, and > > audit expects the non-truncated return value. Other architectures don't > > truncate here, so I think we're setting ourselves up for a game of > > whack-a-mole to truncate and extend wherever we need to. > > > > Given that, I suspect it'd be better to do something like the below. > > > > Will, thoughts? > > I think perf is one example, but this is also visible to userspace via the > native ptrace interface and I distinctly remember needing this for some > versions of arm64 strace to work correctly when tracing compat tasks. FWIW, you've convinced me on your approach (more on that below), but when I went digging here this didn't seem to be exposed via ptrace -- for any task tracing a compat task, the GPRs are exposed via compat_gpr_{get,set}(), which always truncate to compat_ulong_t, giving the lower 32 bits. See task_user_regset_view() for where we get the regset. Am I missing something, or are you thinking of another issue you fixed at the same time? > So I do think that clearing the upper bits on the return path is the right > approach, but it sounds like we need some more work to handle syscall(-1) > and audit (what exactly is the problem here after these patches have been > applied?) >>From digging a bit more, I think I agree, and I think these patches are sufficient for audit. I have some comments I'll leave separately. The remaining issues are wherever we assign a signed value to a compat GPR without explicit truncation. That'll leak via perf sampling the user regs, but I haven't managed to convince myself whether that causes any functional change in behaviour for audit, seccomp, or syscall tracing. Since we mostly use compat_ulong_t for intermediate values in compat code, it does look like this is only an issue for x0 where we assign an error value, e.g. the -ENOSYS case in el0_svc_common. I'll go see if I can find any more. With those fixed up we can remove the x0 truncation from entry.S, which'd be nice too. Thanks, Mark. -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit