From: Paul Moore <paul@paul-moore.com>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: "moderated list:AUDIT SUBSYSTEM" <linux-audit@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 1/2] audit: change unnecessary globals into statics
Date: Thu, 6 Aug 2020 14:33:48 -0400 [thread overview]
Message-ID: <CAHC9VhR1-=veLYGeRiF9MAi3QxrGy_z-q+B1DD9t-foPPRJmbA@mail.gmail.com> (raw)
In-Reply-To: <20200803123439.83400-2-jbi.octave@gmail.com>
On Mon, Aug 3, 2020 at 8:35 AM Jules Irenge <jbi.octave@gmail.com> wrote:
>
> Variables sig_pid, audit_sig_uid and audit_sig_sid
> are only used in the audit.c file across the kernel
> Hence it appears no reason for declaring them as globals
> This patch removes their global declarations from the .h file
> and change them into static in the .c file.
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> kernel/audit.c | 6 +++---
> kernel/audit.h | 4 ----
> 2 files changed, 3 insertions(+), 7 deletions(-)
Thanks Jules, this looks reasonable although I'm not going to merge
them into audit/next until after the merge window closes. I'll send
another reply once this has been merged.
--
paul moore
www.paul-moore.com
--
Linux-audit mailing list
Linux-audit@redhat.com
https://www.redhat.com/mailman/listinfo/linux-audit
next prev parent reply other threads:[~2020-08-06 18:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0/2>
[not found] ` <20200803122430.82364-1-jbi.octave@gmail.com>
2020-08-03 12:24 ` [PATCH 1/2] audit: change unnecessary globals into statics Jules Irenge
2020-08-03 12:24 ` [PATCH 2/2] audit: uninitialize variable audit_sig_sid Jules Irenge
[not found] ` <20200803123439.83400-1-jbi.octave@gmail.com>
2020-08-03 12:34 ` [RESEND PATCH 1/2] audit: change unnecessary globals into statics Jules Irenge
2020-08-06 18:33 ` Paul Moore [this message]
2020-08-18 0:38 ` Paul Moore
2020-08-03 12:34 ` [RESEND PATCH 2/2] audit: uninitialize variable audit_sig_sid Jules Irenge
2020-08-06 18:35 ` Paul Moore
2020-08-18 0:38 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhR1-=veLYGeRiF9MAi3QxrGy_z-q+B1DD9t-foPPRJmbA@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=jbi.octave@gmail.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).