From: Paul Moore <paul@paul-moore.com>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: "moderated list:AUDIT SUBSYSTEM" <linux-audit@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] audit: uninitialize static variables
Date: Sat, 1 Aug 2020 16:21:15 -0400 [thread overview]
Message-ID: <CAHC9VhTQTvr2+TTL3rWyweVEDx_=q81YozPJyfhELOpn9zxDqA@mail.gmail.com> (raw)
In-Reply-To: <20200801184603.310769-4-jbi.octave@gmail.com>
On Sat, Aug 1, 2020 at 2:46 PM Jules Irenge <jbi.octave@gmail.com> wrote:
>
> Checkpatch tool reports an error at variable declaration
>
> "ERROR: do not initialise statics to 0"
>
> This is due to the fact that these variables are stored in the buffer
> In the .bss section, one can not set an initial value
> Here we can trust the compiler to automatically set them to zero.
> The variable has since been uninitialized.
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> kernel/audit.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
In general this is fine, but it will have to wait until after the
merge window closes.
> diff --git a/kernel/audit.c b/kernel/audit.c
> index 7b1a38a211a9..7d79ecb58b01 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -311,8 +311,8 @@ void audit_panic(const char *message)
>
> static inline int audit_rate_check(void)
> {
> - static unsigned long last_check = 0;
> - static int messages = 0;
> + static unsigned long last_check;
> + static int messages;
> static DEFINE_SPINLOCK(lock);
> unsigned long flags;
> unsigned long now;
> @@ -348,7 +348,7 @@ static inline int audit_rate_check(void)
> */
> void audit_log_lost(const char *message)
> {
> - static unsigned long last_msg = 0;
> + static unsigned long last_msg;
> static DEFINE_SPINLOCK(lock);
> unsigned long flags;
> unsigned long now;
> @@ -713,7 +713,7 @@ static int kauditd_send_queue(struct sock *sk, u32 portid,
> {
> int rc = 0;
> struct sk_buff *skb;
> - static unsigned int failed = 0;
> + static unsigned int failed;
>
> /* NOTE: kauditd_thread takes care of all our locking, we just use
> * the netlink info passed to us (e.g. sk and portid) */
> --
> 2.26.2
--
paul moore
www.paul-moore.com
--
Linux-audit mailing list
Linux-audit@redhat.com
https://www.redhat.com/mailman/listinfo/linux-audit
prev parent reply other threads:[~2020-08-01 20:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0/4>
[not found] ` <20200801184603.310769-1-jbi.octave@gmail.com>
2020-08-01 18:46 ` [PATCH 2/4] audit: uninitialize global variable audit_sig_sid Jules Irenge
2020-08-01 18:55 ` Joe Perches
2020-08-01 20:26 ` Paul Moore
2020-08-02 14:32 ` Jules Irenge
2020-08-01 18:46 ` [PATCH 3/4] audit: uninitialize static variables Jules Irenge
2020-08-01 20:21 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhTQTvr2+TTL3rWyweVEDx_=q81YozPJyfhELOpn9zxDqA@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=jbi.octave@gmail.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).