From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70308125AB for ; Fri, 29 Dec 2023 15:44:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="M+2T/wGS" Received: by mail-io1-f48.google.com with SMTP id ca18e2360f4ac-7bb06f56fe9so36726539f.0 for ; Fri, 29 Dec 2023 07:44:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1703864675; x=1704469475; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yQjXtcB6Oq3k74ay/cs5vR/HD/xg6rvyoXPDzdeumLU=; b=M+2T/wGSQyR+xOT6bEIjpUQ7BX8U8lUUT/v1A1LORP9HJsxTMQ/3JNXb2zWkAp93Im v/+Z2OtRH2f2bZ6Zqr57bqRc3+zDX4WvJ1kVTx6PohPIDpf904MbkFPPGvqJut37njrT xXTPc/Pvlflq78TaaXnb0LGKKS0eXniSMMwCQRR30qW5LvKhGf7HsEr3ymKuQ32INjsU EAgyPjIofSEkCw3iliOn/ktT5D1jGPzyD9XjQvMF2aMfiQcr3w5zau1OLVoSuwpQbW/z iBHlnFL1p3OM/O5iyxpJFLhXYKMIZpi5LRa/MJVGu+8paByFfebwGsmY2lRaTKwV4O+E vrkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703864675; x=1704469475; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yQjXtcB6Oq3k74ay/cs5vR/HD/xg6rvyoXPDzdeumLU=; b=ckfAp3wc+AqWOQvA2qOWioysGAVk+cY2IcvI/tAYSkdLGTfNg0FMKgmWwyenTklmY5 dBOdcKwIrSXHbIu9jb/3HcN6laIJ2QV4Aa5GwQvOFZsC2obQm9yvBpRIBoZyTtOjk+Pu oj+D6Q/xOtz59ug8K3gMwrVHpLfGdIpwE3NC2gEMShgBvLZYjEEEY+c7+4Oxg556VofE Q9+YFC1nrM25tSP1Ha6+NMQjyFWyoKRC+DDPCVnn+ja0Mmw1sDhixvs9Yc72sJLAHXHG FDTUlzi/R+cJKWJhSSF1BazUTfz1sMMvD9175y3UspNUCZcBUV4nxB08JhoQTOmZkXHb ZCUA== X-Gm-Message-State: AOJu0YwKlx36+8XXSCKsC02r41Pmy1Snhl7peLMcOU/NjNGIimgAEO/q XeK6Jm9FpGjTThYcR+xZD/x1tkQGcfyoig== X-Google-Smtp-Source: AGHT+IHAm0ro/JYGZ86leiXTCWBYht33pHhUQxq1wRsVw6jMpELsHFapyFrv/5iAU4fxQiP4l1Rgag== X-Received: by 2002:a05:6e02:1d13:b0:35f:da7a:3797 with SMTP id i19-20020a056e021d1300b0035fda7a3797mr22028997ila.1.1703864675229; Fri, 29 Dec 2023 07:44:35 -0800 (PST) Received: from [127.0.0.1] ([198.8.77.194]) by smtp.gmail.com with ESMTPSA id z11-20020a634c0b000000b005ce6b79ab6asm1526889pga.82.2023.12.29.07.44.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Dec 2023 07:44:34 -0800 (PST) From: Jens Axboe To: Christoph Hellwig Cc: Richard Weinberger , Anton Ivanov , Josef Bacik , Minchan Kim , Sergey Senozhatsky , Coly Li , Miquel Raynal , Vignesh Raghavendra , linux-um@lists.infradead.org, linux-block@vger.kernel.org, nbd@other.debian.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org In-Reply-To: <20231228075545.362768-1-hch@lst.de> References: <20231228075545.362768-1-hch@lst.de> Subject: Re: provide a sane discard_granularity default Message-Id: <170386467352.1470147.12182761923584971917.b4-ty@kernel.dk> Date: Fri, 29 Dec 2023 08:44:33 -0700 Precedence: bulk X-Mailing-List: linux-bcache@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-7edf1 On Thu, 28 Dec 2023 07:55:36 +0000, Christoph Hellwig wrote: > this series defaults the discard_granularity to the sector size as > that is a very logical default for devices that have no further > restrictions. This removes the need for trivial drivers to set > a discard granularity and cleans up the interface. > > Diffstat: > arch/um/drivers/ubd_kern.c | 1 - > block/blk-merge.c | 6 +----- > block/blk-settings.c | 5 ++++- > drivers/block/nbd.c | 6 +----- > drivers/block/null_blk/main.c | 1 - > drivers/block/zram/zram_drv.c | 1 - > drivers/md/bcache/super.c | 1 - > drivers/mtd/mtd_blkdevs.c | 4 +--- > 8 files changed, 7 insertions(+), 18 deletions(-) > > [...] Applied, thanks! [1/9] block: remove two comments in bio_split_discard commit: 928a5dd3a849dc6d8298835bdcb25c360d41bccb [2/9] bcache: discard_granularity should not be smaller than a sector commit: 5e7169e7f7c0989304dbe8467a1d703d614c64db [3/9] block: default the discard granularity to sector size commit: 3c407dc723bbf914f3744b0c2bb82265b411a50c [4/9] ubd: use the default discard granularity commit: 599d9d4eab7c3d5dc6f1e0f8f052fee9eaa54e50 [5/9] nbd: use the default discard granularity commit: 1e2ab2e8a98c9e0629b5b8bff8ee6f2cb3e8daac [6/9] null_blk: use the default discard granularity commit: 724325477f8a48ce1defc2a49998bbc19fe85c88 [7/9] zram: use the default discard granularity commit: 3753039def5d0d1c43af847b507ba9b782db183a [8/9] bcache: use the default discard granularity commit: 105c1a5f6ccef7f52f9e76664407ef96218272eb [9/9] mtd_blkdevs: use the default discard granularity commit: 31e4fac930814f2f92eb6ebac9c4d4e3b09f7aaf Best regards, -- Jens Axboe