From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Geoff Levand <geoff@infradead.org>,
Ilya Dryomov <idryomov@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>, Song Liu <song@kernel.org>,
Mike Snitzer <snitzer@redhat.com>, Coly Li <colyli@suse.de>,
Stefan Haberland <sth@linux.ibm.com>,
Jan Hoeppner <hoeppner@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Phillip Lougher <phillip@squashfs.org.uk>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
linux-um@lists.infradead.org, ceph-devel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: [PATCH 02/15] block: use bvec_virt in bio_integrity_{process,free}
Date: Wed, 4 Aug 2021 11:56:21 +0200 [thread overview]
Message-ID: <20210804095634.460779-3-hch@lst.de> (raw)
In-Reply-To: <20210804095634.460779-1-hch@lst.de>
Use the bvec_virt helper to clean up the bio integrity processing a
little bit.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
block/bio-integrity.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/block/bio-integrity.c b/block/bio-integrity.c
index 8f54d49dc500..6b47cddbbca1 100644
--- a/block/bio-integrity.c
+++ b/block/bio-integrity.c
@@ -104,8 +104,7 @@ void bio_integrity_free(struct bio *bio)
struct bio_set *bs = bio->bi_pool;
if (bip->bip_flags & BIP_BLOCK_INTEGRITY)
- kfree(page_address(bip->bip_vec->bv_page) +
- bip->bip_vec->bv_offset);
+ kfree(bvec_virt(bip->bip_vec));
__bio_integrity_free(bs, bip);
bio->bi_integrity = NULL;
@@ -163,13 +162,11 @@ static blk_status_t bio_integrity_process(struct bio *bio,
struct bio_vec bv;
struct bio_integrity_payload *bip = bio_integrity(bio);
blk_status_t ret = BLK_STS_OK;
- void *prot_buf = page_address(bip->bip_vec->bv_page) +
- bip->bip_vec->bv_offset;
iter.disk_name = bio->bi_bdev->bd_disk->disk_name;
iter.interval = 1 << bi->interval_exp;
iter.seed = proc_iter->bi_sector;
- iter.prot_buf = prot_buf;
+ iter.prot_buf = bvec_virt(bip->bip_vec);
__bio_for_each_segment(bv, bio, bviter, *proc_iter) {
void *kaddr = bvec_kmap_local(&bv);
--
2.30.2
next prev parent reply other threads:[~2021-08-04 10:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 9:56 add a bvec_virt helper Christoph Hellwig
2021-08-04 9:56 ` [PATCH 01/15] bvec: " Christoph Hellwig
2021-08-05 6:19 ` Chaitanya Kulkarni
2021-08-06 2:38 ` Martin K. Petersen
2021-08-04 9:56 ` Christoph Hellwig [this message]
2021-08-05 6:19 ` [PATCH 02/15] block: use bvec_virt in bio_integrity_{process,free} Chaitanya Kulkarni
2021-08-06 2:38 ` Martin K. Petersen
2021-08-04 9:56 ` [PATCH 03/15] dm: make EBS depend on !HIGHMEM Christoph Hellwig
2021-08-04 9:56 ` [PATCH 04/15] dm-ebs: use bvec_virt Christoph Hellwig
2021-08-04 9:56 ` [PATCH 05/15] dm-integrity: " Christoph Hellwig
2021-08-04 9:56 ` [PATCH 06/15] squashfs: " Christoph Hellwig
2021-08-04 9:56 ` [PATCH 07/15] rbd: " Christoph Hellwig
2021-08-05 12:01 ` Jeff Layton
2021-08-04 9:56 ` [PATCH 08/15] virtio_blk: " Christoph Hellwig
2021-08-05 14:17 ` Stefan Hajnoczi
2021-08-04 9:56 ` [PATCH 09/15] bcache: " Christoph Hellwig
2021-08-04 17:05 ` Coly Li
2021-08-04 9:56 ` [PATCH 10/15] sd: " Christoph Hellwig
2021-08-05 16:31 ` [dm-devel] " Bart Van Assche
2021-08-06 2:43 ` Martin K. Petersen
2021-08-04 9:56 ` [PATCH 11/15] ubd: " Christoph Hellwig
2021-08-04 10:10 ` Anton Ivanov
2021-08-04 9:56 ` [PATCH 12/15] ps3vram: " Christoph Hellwig
2021-08-04 9:56 ` [PATCH 13/15] dasd: " Christoph Hellwig
2021-08-04 20:20 ` Stefan Haberland
2021-08-04 9:56 ` [PATCH 14/15] dcssblk: " Christoph Hellwig
2021-08-04 9:56 ` [PATCH 15/15] nvme: " Christoph Hellwig
2021-08-04 14:33 ` Keith Busch
2021-08-16 12:38 ` add a bvec_virt helper Christoph Hellwig
2021-08-16 16:51 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210804095634.460779-3-hch@lst.de \
--to=hch@lst.de \
--cc=anton.ivanov@cambridgegreys.com \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=colyli@suse.de \
--cc=dm-devel@redhat.com \
--cc=geoff@infradead.org \
--cc=hoeppner@linux.ibm.com \
--cc=idryomov@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=pbonzini@redhat.com \
--cc=phillip@squashfs.org.uk \
--cc=richard@nod.at \
--cc=snitzer@redhat.com \
--cc=song@kernel.org \
--cc=stefanha@redhat.com \
--cc=sth@linux.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).